Error logs - #5
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Write refusals to stderr as well as stdout, so the platform's error dialog shows them
Greptile Summary
The PR writes user-facing analysis refusals to both stdout and stderr so they remain in the run log and also appear in the platform error dialog. No actionable defects were identified.
Confidence Score: 5/5
The PR appears safe to merge, with refusal details deliberately routed to the two distinct platform-facing output channels.
The refusal branch retains its existing stdout diagnostic and exit behavior, adds a valid stderr write, and the updated integration tests cover the reachable validation failures.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR V[Validation failure] --> R[Refusal handler] R --> O[stdout: run log] R --> E[stderr: platform error dialog] R --> X[Exit status 1]Reviews (1): Last reviewed commit: "Write refusals to stderr as well as stdo..." | Re-trigger Greptile
Context used (4)