Support vdj modality for DMS datasets - #9
Open
mzueva wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This PR recognizes producer-declared VDJ modality when constructing embedding scopes, introduces an explicit unknown-receptor state, broadens model selection for DMS VDJ data, and updates Platforma SDK dependencies.
pl7.app/modality; the PR detects"vdj"and uses it to distinguish V-domain sequences from ordinary amplicon/peptide sequences.amplicon-sequencecolumns now becomeVDJRegion, while VDJCDR3region columns becomeCDR3.ScopeReceptortype extendsWorkflowReceptorwith"unknown"when VDJ data supplies neither receptor nor chain metadata.CDR3columns represented aspl7.app/sequence.Confidence Score: 5/5
The PR appears safe to merge because no concrete changed-code defect or actionable security issue remains.
The new modality classification, receptor representation, compatibility filtering, and dependency refresh are internally consistent, and the potentially surprising model-selection behavior is explicitly documented as intentional.
Important Files Changed
ScopeReceptor, relaxes specialization gates for unknown receptors, and defaults those scopes to ESM-2.ScopeReceptorand propagates it through persisted selected scopes and generated scope configuration.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Input entity-axis metadata] --> B{pl7.app/modality is vdj?} B -- No --> C[Classify amplicon sequence as peptide] B -- Yes --> D[Classify whole variant as VDJRegion] B -- Yes --> E[Classify region column as CDR3] A --> F{Receptor or chain supplied?} F -- Yes --> G[Resolve IG, TCRAB, or TCRGD] F -- No, VDJ --> H[ScopeReceptor unknown] G --> I[Apply receptor and heavy-chain model gates] H --> J[Offer feature-compatible VDJ models] J --> K[Default to ESM-2] C --> L[Build selectable scope configuration] D --> L E --> L I --> L K --> LReviews (1): Last reviewed commit: "Support vdj modality for DMS datasets" | Re-trigger Greptile
Context used: