fix(pick): show local times on Windows - #82
Merged
Merged
Conversation
backnotprop
force-pushed
the
fix/windows-local-time
branch
2 times, most recently
from
September 21, 2026 20:22
22bacac to
fdb999e
Compare
The offset lookup returned zero everywhere but Unix, so the reply picker showed UTC on Windows. The time crate's local-offset feature reads the zone the OS reports; the Unix path is unchanged.
backnotprop
force-pushed
the
fix/windows-local-time
branch
from
September 21, 2026 20:22
fdb999e to
2fb7283
Compare
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reply picker's clock offset came from
date +%zon Unix and was zero everywhere else, so Windows showed UTC. This enables thetimecrate'slocal-offsetfeature (already a dependency) and usesUtcOffset::current_local_offset()on Windows only; the Unix path is unchanged. A cross-platform test asserts the offset is a real time zone, so the Windows CI job exercises the new path.