Repository navigation
Conversation
GLEP 67 v1.2 adds proxied="maintainer-and-proxy" for a developer who maintains a package and also serves as a proxy for its proxied maintainers. The proxy maintainer checks raised a KeyError on it. Count such a maintainer as a proxy. The testdata gentoo repo gets a metadata.xsd that accepts it, taken from data/xml-schema.git commit 0b779b433d5cbb76343a192833f3c96b8a974fa0. Signed-off-by: Matt Turner <mattst88@gentoo.org>
…esses A maintainer without a gentoo.org address cannot push changes directly, so should be listed with proxied="yes". Without the attribute, GLEP 67 assumes proxied="no", saying that they can. Add UnmarkedProxiedMaintainer for those without it or with proxied="no". A gentoo.org address may also lack commit access, so proxied="yes" is not flagged there. A proxy pushes changes for proxied maintainers, which needs commit access. Add NonGentooProxy for proxied="proxy" or proxied="maintainer-and-proxy" without a gentoo.org address, and give the proxy in the MaintainerWithoutProxy fix one. Signed-off-by: Matt Turner <mattst88@gentoo.org>
proxy-maint@gentoo.org serves only as a proxy for proxied maintainers, which GLEP 67 expresses as proxied="proxy". Without the attribute, proxied="no" is assumed. Add UnmarkedProxyMaint for proxy-maint listed without it. Signed-off-by: Matt Turner <mattst88@gentoo.org>
GLEP 67 says that if a maintainer is listed with proxied="yes", at least one other should be listed with proxied="proxy" or proxied="maintainer-and-proxy". MaintainerWithoutProxy only flagged packages where no maintainer was a developer or a proxy, so a proxied maintainer co-maintaining with a developer passed. Flag those too, and list only the proxied maintainers, since others may be listed. The fix for a co-maintaining developer marks them with proxied="maintainer-and-proxy", added in GLEP 67 v1.2, since they maintain the package as well as serve as its proxy. Signed-off-by: Matt Turner <mattst88@gentoo.org>
… e-mail GLEP 68 v1.6 adds cc-on-bugs="yes" for an upstream maintainer who wants to be CC-ed on bugs, and requires an <email/> element with it. The XSD cannot express that, since email is otherwise optional. Add CcOnBugsWithoutEmail for an upstream maintainer with cc-on-bugs="yes" and no e-mail. The attribute is read from the XML rather than from pkgcore's UpstreamMaintainer, which does not have it in released versions. UnmarkedProxiedMaintainer now suggests moving an upstream developer listed only to be CC-ed on bugs to <upstream/> with cc-on-bugs="yes". The testdata gentoo repo's metadata.xsd is updated to accept it, as in data/xml-schema.git commit 0d43c60a151b103c6bb3e93b6e644bf2c63bedcb. Bug: https://bugs.gentoo.org/985978 Signed-off-by: Matt Turner <mattst88@gentoo.org>
mattst88
force-pushed
the
maintainer-attributes
branch
from
November 17, 2026 20:07
fbcdeb7 to
6bf5228
Compare
Signed-off-by: Matt Turner <mattst88@gentoo.org>
gentoo-bot
pushed a commit
that referenced
this pull request
Nov 18, 2026
GLEP 67 v1.2 adds proxied="maintainer-and-proxy" for a developer who maintains a package and also serves as a proxy for its proxied maintainers. The proxy maintainer checks raised a KeyError on it. Count such a maintainer as a proxy. The testdata gentoo repo gets a metadata.xsd that accepts it, taken from data/xml-schema.git commit 0b779b433d5cbb76343a192833f3c96b8a974fa0. Signed-off-by: Matt Turner <mattst88@gentoo.org> Part-of: #796 Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
gentoo-bot
pushed a commit
that referenced
this pull request
Nov 18, 2026
…esses A maintainer without a gentoo.org address cannot push changes directly, so should be listed with proxied="yes". Without the attribute, GLEP 67 assumes proxied="no", saying that they can. Add UnmarkedProxiedMaintainer for those without it or with proxied="no". A gentoo.org address may also lack commit access, so proxied="yes" is not flagged there. A proxy pushes changes for proxied maintainers, which needs commit access. Add NonGentooProxy for proxied="proxy" or proxied="maintainer-and-proxy" without a gentoo.org address, and give the proxy in the MaintainerWithoutProxy fix one. Signed-off-by: Matt Turner <mattst88@gentoo.org> Part-of: #796 Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
gentoo-bot
pushed a commit
that referenced
this pull request
Nov 18, 2026
proxy-maint@gentoo.org serves only as a proxy for proxied maintainers, which GLEP 67 expresses as proxied="proxy". Without the attribute, proxied="no" is assumed. Add UnmarkedProxyMaint for proxy-maint listed without it. Signed-off-by: Matt Turner <mattst88@gentoo.org> Part-of: #796 Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
gentoo-bot
pushed a commit
that referenced
this pull request
Nov 18, 2026
GLEP 67 says that if a maintainer is listed with proxied="yes", at least one other should be listed with proxied="proxy" or proxied="maintainer-and-proxy". MaintainerWithoutProxy only flagged packages where no maintainer was a developer or a proxy, so a proxied maintainer co-maintaining with a developer passed. Flag those too, and list only the proxied maintainers, since others may be listed. The fix for a co-maintaining developer marks them with proxied="maintainer-and-proxy", added in GLEP 67 v1.2, since they maintain the package as well as serve as its proxy. Signed-off-by: Matt Turner <mattst88@gentoo.org> Part-of: #796 Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
gentoo-bot
pushed a commit
that referenced
this pull request
Nov 18, 2026
… e-mail GLEP 68 v1.6 adds cc-on-bugs="yes" for an upstream maintainer who wants to be CC-ed on bugs, and requires an <email/> element with it. The XSD cannot express that, since email is otherwise optional. Add CcOnBugsWithoutEmail for an upstream maintainer with cc-on-bugs="yes" and no e-mail. The attribute is read from the XML rather than from pkgcore's UpstreamMaintainer, which does not have it in released versions. UnmarkedProxiedMaintainer now suggests moving an upstream developer listed only to be CC-ed on bugs to <upstream/> with cc-on-bugs="yes". The testdata gentoo repo's metadata.xsd is updated to accept it, as in data/xml-schema.git commit 0d43c60a151b103c6bb3e93b6e644bf2c63bedcb. Bug: https://bugs.gentoo.org/985978 Signed-off-by: Matt Turner <mattst88@gentoo.org> Part-of: #796 Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five commits for the GLEP 67/68 changes per bug https://bugs.gentoo.org/985978. The xml-schema and dtd changes are in
and should be merged today.
I have fixes for all the new checks ready to go in gentoo.git.