Skip to content

fix(mobile): show high usage limit fills - #9742

Open
none23 wants to merge 1 commit into
pingdotgg:mainfrom
none23:fix/android-usage-bar-fill
Open

fix(mobile): show high usage limit fills#9742
none23 wants to merge 1 commit into
pingdotgg:mainfrom
none23:fix/android-usage-bar-fill

Conversation

@none23

@none23 none23 commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

What Changed

Mobile now exposes the shared warning and destructive color roles through its Uniwind theme variables, including generated custom themes.

Why

Usage limit fills already use semantic warning and destructive classes, but mobile did not register those colors. Defining the missing theme variables makes the fills visible while preserving each theme’s palette.

UI Changes

Before After
image image

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Authored with GPT-5.6 Sol via the Codex harness in T3 Code.


Note

Low Risk
Theme-token and generated CSS updates only; no auth, data, or business-logic changes.

Overview
Adds --color-warning and --color-destructive to the mobile Uniwind theme so semantic bg-warning / bg-destructive classes (e.g. usage limit progress fills) resolve instead of rendering invisible.

createMobileThemeVariables now maps shared palette warning and error into those CSS variables; default global.css light/dark tokens and regenerated generated-uniwind-* outputs include per-theme values. Tests expect 67 theme variables and assert the new mappings.

Reviewed by Cursor Bugbot for commit 29d7b3f. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add warning and destructive color variables to mobile themes

  • Adds warning and destructive custom properties to both light and dark mobile theme definitions in global.css, with generated output in the Uniwind theme files
  • createMobileThemeVariables in mobileTheme.ts now maps warning from the native warning color and destructive from the native error color of the selected ThemeColors palette
  • Updates the palette mapping test in mobileTheme.test.ts to expect 67 generated variables (up from 65) and verify the new mappings
  • Risk: consumers relying on the exact count of generated mobile theme variables (65) will need to update for the two new additions

Macroscope summarized 29d7b3f.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Sep 4, 2026
macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Sep 4, 2026
@macroscopeapp

macroscopeapp Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This change wires warning and destructive colors into existing mobile usage-limit rendering and updates the shipped light/dark and built-in theme defaults. Because it changes product defaults across the mobile theme system, human review is warranted.

You can add or adjust custom eligibility rules. Learn more.

@none23
none23 marked this pull request as draft September 4, 2026 18:18
@none23
none23 force-pushed the fix/android-usage-bar-fill branch from de4c226 to eaea60a Compare September 4, 2026 18:25
@github-actions github-actions Bot added size:M 30-99 changed lines (additions + deletions). and removed size:XS 0-9 changed lines (additions + deletions). labels Sep 4, 2026
@none23
none23 force-pushed the fix/android-usage-bar-fill branch from eaea60a to 59d2abe Compare September 4, 2026 18:30
@none23
none23 force-pushed the fix/android-usage-bar-fill branch from 59d2abe to 29d7b3f Compare September 4, 2026 18:35
@none23
none23 marked this pull request as ready for review September 4, 2026 19:30
@macroscopeapp
macroscopeapp Bot dismissed their stale review September 4, 2026 19:33

Dismissing prior approval to re-evaluate 29d7b3f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant