ci: SHA-pin actions in pr-size workflow and drop dead job#4135
ci: SHA-pin actions in pr-size workflow and drop dead job#4135kridaydave wants to merge 3 commits into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 512d84a. Configure here.
ApprovabilityVerdict: Approved CI workflow cleanup (SHA-pinning actions, removing dead job) and new contributor documentation. No runtime behavior changes. The open review comment is a low-severity doc inconsistency that doesn't block approval. You can customize Macroscope's approvability policy. Learn more. |
Dismissing prior approval to re-evaluate ae95dfd

Hardened .github/workflows/pr-size.yml:
YAML structure verified; label job still wired correctly.
Note
Low Risk
CI-only changes; PR size labeling behavior is unchanged aside from no longer auto-syncing label colors/descriptions via the removed dead job.
Overview
Hardens the PR size workflow by pinning
actions/checkoutandactions/github-scriptto commit SHAs instead of floating major tags, and documents why thepull_request_targetcheckout stays on the base branch only.Removes the
sync-label-definitionsjob, which could never run because itsifexcludedpull_request_targetwhile the workflow only triggers on that event.prepare-confignow outputs label names only (no color/description), which is all the remaininglabeljob needs. Adds inline comments on passive PR commit handling when bumping checkout.Also adds
docs/project/good-first-prs.md, a contributor audit list (tests, CI, docs), and marks related items such as the checkout bump and deadsync-label-definitionsjob as done.Reviewed by Cursor Bugbot for commit ec0d5cd. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Pin actions to commit SHAs and remove label-sync job in pr-size workflow
actions/github-scriptandactions/checkoutto specific commit SHAs in pr-size.yml instead of floating major version tags.sync-label-definitionsjob, which previously created and updated PR size label color/description via the GitHub Issues API.prepare-configoutput now includes only labelnamefields, droppingcoloranddescription.Macroscope summarized ec0d5cd.