Finale: upgrade changed files card to fix various UI issues#4113
Finale: upgrade changed files card to fix various UI issues#4113sandersonstabo wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f27a82a. Configure here.
ApprovabilityVerdict: Approved Pure UI styling changes: CSS class adjustments, singular/plural grammar fix, and layout restructuring. No logic or runtime behavior changes beyond visual presentation. You can customize Macroscope's approvability policy. Learn more. |
Dismissing prior approval to re-evaluate d55d1a4

Why
When merging the original UI PR this section was left in a kind of hybrid state, it had some changes merged but not all. I highly suggest merging this version instead as the last one has contrast issues, padding issues and visual noise that is not needed. Also unifies the radii of the card to be like the others.
Now available as 25 line addition, not the 9K one that was mistakenly generated!
UI changes
Before:
After:
Checklist
Testing
vp check;vp run typecheckpassed locally before splitting these PRs.Note
Low Risk
Presentation-only Tailwind/className updates; no logic, data, or behavior changes beyond copy pluralization.
Overview
Aligns the changed files UI in
ChangedFilesCardand the assistant timeline block (AssistantChangedFilesSectionInner) to the same card treatment:rounded-2xl,border-input,bg-background, light shadow, anddark:bg-input/32instead of semi-transparent card layers, pseudo-borders, and sticky blurred headers.The header is a normal flex row (not sticky): “N changed file(s)” with proper pluralization, inline
DiffStatLabel(layout="inline",text-xs), and Collapse all / View diff outline buttons with tighterpx-1.5. InChangedFilesCard, the extra inner padding wrapper aroundChangedFilesTreeis removed so the tree sits directly in the card.Reviewed by Cursor Bugbot for commit d55d1a4. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix UI issues in the changed files card header and diff stat display
ChangedFilesCardandAssistantChangedFilesSectionInner, replacing it with a bordered, rounded card layout.DiffStatLabelinline with compact text sizing (text-xs leading-4) and reduces horizontal padding on action buttons.Macroscope summarized d55d1a4.