Skip to content

fix hyphen inconsistency in DM-master/DM-worker mentions - #23645

Draft
yahonda wants to merge 1 commit into
release-8.5from
fix-dm-master-worker-hyphen-en
Draft

fix hyphen inconsistency in DM-master/DM-worker mentions#23645
yahonda wants to merge 1 commit into
release-8.5from
fix-dm-master-worker-hyphen-en

Conversation

@yahonda

@yahonda yahonda commented Aug 28, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

DM-master and DM-worker are the actual TiDB Data Migration (DM) tool component/binary names, matching the dm-master/dm-worker binaries and dm/master, dm/worker paths. This corpus almost always hyphenates them (290 DM-master / 409 DM-worker occurrences) but 16 sites across 11 files used a space instead of a hyphen (DM master / DM worker).

Found while reviewing a Japanese translation PR that unifies katakana DMマスター/DMワーカー renderings to the literal English form (pingcap/docs#23635) — checking whether EN itself had the same kind of inconsistency.

Unifies to the dominant hyphenated form, using a word-boundary-safe substitution (\bDM master\b / \bDM worker\b) to avoid any accidental match inside a longer word.

11 files, 16 sites.

Verified markdownlint-cli2 clean on all touched files.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s): found while reviewing pingcap/docs#23635

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

DM-master and DM-worker are the TiDB Data Migration (DM) tool
component names, matching the dm-master/dm-worker binaries. This
corpus almost always hyphenates them (290/409 occurrences) but 16
sites across 11 files used a space instead. Unifies to the dominant
hyphenated form.
@ti-chi-bot

ti-chi-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 28, 2026
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot

ti-chi-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lilin90 for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant