i18n(ja): unify the optimizer fix control feature name notation - #23630
Merged
Conversation
Direction decided 2026-07-24/08-04: オプティマイザ (no ー) matches the dominant corpus form and optimizer-hints.md's own H1. Fresh recount: 592 no-vowel vs 259 with-vowel (~70/30). Mechanical substring replace, verified 0 remaining オプティマイザー and no double-vowel artifacts. 116 files, 259 occurrences.
Optimizer Fix Controls (and the per-item "fix control") is a specific TiDB feature/mechanism name, not a descriptive phrase, so it should stay literal rather than be translated as オプティマイザ修正制御/ オプティマイザ修正コントロール. Also fixes a stray dangling text fragment in release-7.2.0.md and unifies 派生範囲/行式 in multi-column-index-best-practices.md to match the file's own established 導出 terminology and natural JA phrasing.
ti-chi-bot
Bot
added
area/develop
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
the
size/XL
📝 WalkthroughWalkthroughChangesOptimizer documentation terminology
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: 🔵 Low · up to The PR is mergeable with explicit owner follow-up for several localized Japanese documentation issues, including an inconsistent link label, imprecise release-note wording, a Markdown delimiter defect, and unclear or inconsistent terminology. The likely impact is limited to documentation clarity and rendering. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (13 skipped: 13 unsupported.) Full details: Description checkExplanation The description includes the required change summary, affected version, AI involvement, and change-category checklist. The empty reference-link fields are non-critical because no references are required for this documentation-only change. ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: a86cc6a5-012c-42f4-83ea-960939bdfcbe
📒 Files selected for processing (119)
TOC-tidb-cloud-essential.mdTOC-tidb-cloud-premium.mdTOC-tidb-cloud-starter.mdTOC-tidb-cloud.mdTOC.mdagg-distinct-optimization.mdanalyze-slow-queries.mdbenchmark/benchmark-tidb-using-ch.mdbenchmark/v4.0-performance-benchmarking-with-tpch.mdbest-practices/index-management-best-practices.mdbest-practices/multi-column-index-best-practices.mdcomment-syntax.mdcontrol-execution-plan.mdddl_embedded_analyze.mdderive-topn-from-window.mddevelop/dev-guide-hybrid-oltp-and-olap-queries.mddevelop/dev-guide-index-best-practice.mddevelop/dev-guide-join-tables.mdexplain-index-merge.mdexplain-indexes.mdexplain-joins.mdextended-statistics.mdfaq/sql-faq.mdfunctions-and-operators/tidb-functions.mdgenerated-columns.mdinformation-schema/information-schema-tiflash-replica.mdoptimizer-fix-controls.mdoptimizer-hints.mdquick-start-with-htap.mdreleases/release-1.0-ga.mdreleases/release-1.1-alpha.mdreleases/release-2.0-ga.mdreleases/release-2.0-rc.1.mdreleases/release-2.0.4.mdreleases/release-2.1-beta.mdreleases/release-2.1-ga.mdreleases/release-2.1-rc.1.mdreleases/release-2.1-rc.2.mdreleases/release-2.1-rc.3.mdreleases/release-2.1-rc.4.mdreleases/release-2.1-rc.5.mdreleases/release-2.1.1.mdreleases/release-2.1.16.mdreleases/release-2.1.17.mdreleases/release-2.1.18.mdreleases/release-2.1.19.mdreleases/release-2.1.3.mdreleases/release-2.1.4.mdreleases/release-2.1.5.mdreleases/release-2.1.6.mdreleases/release-3.0-beta.mdreleases/release-3.0-ga.mdreleases/release-3.0.0-beta.1.mdreleases/release-3.0.0-rc.1.mdreleases/release-3.0.0-rc.2.mdreleases/release-3.0.0-rc.3.mdreleases/release-3.0.2.mdreleases/release-3.0.3.mdreleases/release-3.0.4.mdreleases/release-3.0.5.mdreleases/release-3.0.6.mdreleases/release-3.0.8.mdreleases/release-3.1.0-beta.mdreleases/release-5.0.0-rc.mdreleases/release-6.1.0.mdreleases/release-6.1.1.mdreleases/release-6.3.0.mdreleases/release-6.4.0.mdreleases/release-6.5.0.mdreleases/release-6.5.10.mdreleases/release-6.5.7.mdreleases/release-6.6.0.mdreleases/release-7.0.0.mdreleases/release-7.1.0.mdreleases/release-7.1.6.mdreleases/release-7.2.0.mdreleases/release-7.4.0.mdreleases/release-7.5.3.mdreleases/release-7.5.7.mdreleases/release-7.6.0.mdreleases/release-8.0.0.mdreleases/release-8.1.0.mdreleases/release-8.1.1.mdreleases/release-8.4.0.mdreleases/release-pre-ga.mdreleases/release-rc.1.mdreleases/release-rc.2.mdreleases/release-rc.3.mdreleases/release-rc.4.mdsql-non-prepared-plan-cache.mdsql-physical-optimization.mdsql-plan-management.mdsql-plan-replayer.mdsql-prepared-plan-cache.mdsql-statements/sql-statement-alter-index.mdsql-statements/sql-statement-select.mdsql-statements/sql-statement-set-variable.mdsql-tuning-best-practice.mdsubquery-optimization.mdsystem-variable-reference.mdsystem-variables.mdtidb-cloud/releases/release-notes-2022.mdtidb-cloud/serverless-faqs.mdtidb-cloud/tidb-cloud-htap-quickstart.mdtidb-cloud/tidb-cloud-sql-tuning-overview.mdtidb-cloud/v6.5-performance-benchmarking-with-tpcc.mdtidb-cloud/v7.1-performance-benchmarking-with-tpcc.mdtidb-cloud/v7.5-performance-benchmarking-with-tpcc.mdtidb-cloud/v8.1-performance-benchmarking-with-tpcc.mdtidb-cloud/v8.5-performance-benchmarking-with-tpcc.mdtidb-performance-tuning-config.mdtiflash-performance-tuning-methods.mdtiflash/tiflash-late-materialization.mdtiflash/tiflash-overview.mdtiflash/tune-tiflash-performance.mdtiflash/use-tidb-to-read-tiflash.mdtiflash/use-tiflash-mpp-mode.mdtiup/tiup-bench.mdwrong-index-solution.md
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review.
…lish" This reverts commit 483b975.
yahonda
changed the title
ti-chi-bot
Bot
added
size/XXL
yahonda
changed the title
yahonda
force-pushed
the
fix-optimizer-fix-control-term-en
branch
2 times, most recently
from
August 27, 2026 06:07
b94023f to
a7da5a8
Compare
The general feature name (Optimizer Fix Controls, オプティマイザ修正 コントロール) is a normal translated title, like its sibling TOC entries (SQLプラン管理, etc.) — unifies the two competing pre-existing Japanese renderings (修正制御/修正コントロール) to 修正コントロール everywhere it names the feature/mechanism as a whole (page title, headings, TOC/cross-reference links, mechanism-level release-note prose). A reference to one specific numbered fix control item (e.g. "optimizer fix control 54337", "this fix control", "Fix Control #44855") reads more like an identifier than a title, and EN itself never capitalizes these as the branded feature name — kept/restored to English at each such site for consistency with EN and with pre-existing correctly- English sites found in release-8.5.7.md. The system variable identifier `tidb_opt_fix_control` (backticked, a real system variable) stays literal throughout, as it always has. Also fixes, found along the way: - optimizer-fix-controls.md: a scrambled "Possible values" line (可能`OFF`値: `ON` instead of 可能な値: `ON`、`OFF`) repeated 12 times. - releases/release-7.2.0.md: a stray dangling text fragment before a link. - optimizer-fix-controls.md: a missing opening backtick around `tidb_opt_fix_control` in the frontmatter summary. - best-practices/multi-column-index-best-practices.md: 派生範囲/ 派生した範囲 → 導出された範囲 and 行式 → 行の式, matching this file's own established terminology; also a missing space before a bold numbered fix-control reference. - releases/release-8.5.7.md: a missing space between a Japanese particle and an embedded English phrase.
yahonda
force-pushed
the
fix-optimizer-fix-control-term-en
branch
from
August 27, 2026 06:09
a7da5a8 to
7da9b47
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 0cb64b6c-f82c-496b-b55c-f3421e94f8e7
📒 Files selected for processing (13)
TOC-tidb-cloud-essential.mdTOC-tidb-cloud-premium.mdTOC-tidb-cloud-starter.mdTOC-tidb-cloud.mdTOC.mdcontrol-execution-plan.mdoptimizer-fix-controls.mdreleases/release-7.2.0.mdreleases/release-7.3.0.mdreleases/release-8.5.7.mdsystem-variable-reference.mdsystem-variables.mdtidb-performance-tuning-config.md
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.
- agg-distinct-optimization.md: restore a missing opening backtick around distinct, and fix a clause-ordering mistranslation that misattributed "for aggregate functions" to the wrong DISTINCT form. - releases/release-8.4.0.md: complete a dangling sentence about the estRows minimum-value fix control, reusing the phrasing already established on optimizer-fix-controls.md's own entry for the same fix number. - releases/release-7.3.0.md: reword an awkward "optimize the ... issue" translation to the more natural "improve the overestimation".
6 tasks
qiancai
added
translation/no-need
qiancai
approved these changes
Aug 28, 2026
[LGTM Timeline notifier]Timeline:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
The general feature name (
Optimizer Fix Controls, オプティマイザ修正コントロール) is a normal translated title in this corpus, like its sibling TOC entries (SQLプラン管理, etc.) — this PR unifies the two competing pre-existing Japanese renderings for it (修正制御/修正コントロール) to修正コントロールeverywhere it names the feature/mechanism as a whole (page title, headings, TOC/cross-reference links, mechanism-level release-note prose).A reference to one specific numbered fix control item (e.g. "optimizer fix control 54337", "this fix control", "Fix Control #44855") reads more like an identifier than a title, and EN itself never capitalizes these as the branded feature name — kept/restored to English at each such site, for consistency with EN and with pre-existing correctly-English sites already found in
release-8.5.7.md.The system variable identifier
`tidb_opt_fix_control`(backticked, a real system variable) stays literal throughout, as it always has.Also fixed along the way
optimizer-fix-controls.md: a scrambled "Possible values" line (可能\OFF`値: `ON`instead of可能な値: `ON`、`OFF``), repeated 12 times in the file.releases/release-7.2.0.md: a stray dangling text fragment (オプティマ) left before a link.optimizer-fix-controls.md: a missing opening backtick around`tidb_opt_fix_control`in the frontmatter summary.best-practices/multi-column-index-best-practices.md: 派生範囲/派生した範囲 → 導出された範囲 and 行式 → 行の式, matching this file's own established terminology; also a missing space before a bold numbered fix-control reference.releases/release-8.5.7.md: a missing space between a Japanese particle and an embedded English phrase.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?