fix: preserve strategy close-all arguments#63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Preserve Pine strategy.close_all comment and immediately arguments instead of lowering every call to a no-argument close. Also correct the official positional order shared by strategy.close and strategy.close_all.
Implementation
Causal evidence
The existing order-close-all-cancel-all golden previously exited at 06:30 UTC with an empty comment. Regenerated code exits at TradingView 06:15 UTC and preserves exit_comment global flat, with the same exit price.
A census regenerated 39 close_all corpus files containing 46 calls: 44 comment-bearing calls, one immediately=true call, and no unexpected opcode changes. Updating committed engine corpus generated files remains a follow-up after this codegen merge.
Gates
An earlier hard-rejection experiment for unsupported alert controls was rejected after it moved seven Excellent rows to missing. This final head preserves the established warning compatibility boundary.