ci: make npm audit blocking + add Dependabot - #26
Open
jhamon wants to merge 1 commit into
Open
Conversation
- Make the npm audit job blocking (remove continue-on-error) so PRs fail on high/critical JS vulnerabilities. npm audit --audit-level=high is currently clean. - Add .github/dependabot.yml for npm + pip + github-actions (grouped). The Python side has starlette advisories that only resolve via a FastAPI- coordinated major bump (starlette 1.x); those are left for Dependabot to surface rather than forcing a blocking pip-audit gate that would wedge every PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
continue-on-error: true. Now it fails on high/critical JS vulnerabilities (npm audit --audit-level=highis currently clean)..github/dependabot.yml— npm + pip + github-actions (grouped).The existing Node build/lint (22/24 matrix) and Python compile jobs are unchanged.
Note on the Python side
pip-auditflags severalstarlette(0.48.0) advisories that only resolve via a FastAPI-coordinated major bump (starlette 1.x). Forcing a blocking pip-audit gate would wedge every PR on that major, so I left it out — the new pip Dependabot config will surface those bumps for deliberate review instead.Verification (local)
npm audit --audit-level=high→ 0 ✅🤖 Generated with Claude Code
Note
Low Risk
Changes only CI and dependency automation; no application runtime or auth/data paths are modified.
Overview
Tightens JS supply-chain checks in CI by removing
continue-on-errorfrom the audit job and renaming it to reflect thatnpm audit --audit-level=highis now a hard gate (high/critical findings block merges).Adds
.github/dependabot.ymlwith weekly updates for npm, pip, and github-actions, grouping minor/patch bumps and capping open PRs (10 for npm/pip, 5 for actions). Python dependency scanning is not made blocking in CI; pip updates are left to Dependabot for deliberate review (e.g. Starlette/FastAPI major bumps).Reviewed by Cursor Bugbot for commit 141579f. Bugbot is set up for automated code reviews on this repo. Configure here.