[BUG] Grid export: rounded progress, hide notification on download, grid name in messages and file name - #4063
Open
Jonathon-Meney-Torq wants to merge 6 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves grid CSV/XLSX exports with clearer progress, notifications, titles, and filenames.
Changes:
- Rounds job progress to two decimal places.
- Hides completed notifications after successful downloads.
- Adds grid-specific titles and timestamped filenames.
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
translations/studio.en.yaml |
Adds English export titles. |
translations/studio.de.yaml |
Adds German-locale export keys. |
translations/studio.es.yaml |
Adds Spanish-locale export keys. |
translations/studio.fr.yaml |
Adds French-locale export keys. |
translations/studio.it.yaml |
Adds Italian-locale export keys. |
translations/studio.no.yaml |
Adds Norwegian-locale export keys. |
translations/studio.sv.yaml |
Adds Swedish-locale export keys. |
progress-field-calculator.ts |
Rounds determinate progress values. |
message-bus-job-notification.tsx |
Exposes notification hiding callback. |
abstract-download-job.ts |
Supports custom titles and post-download hiding. |
csv-download-job.ts |
Forwards custom CSV job titles. |
xlsx-download-job.ts |
Forwards custom XLSX job titles. |
export-file-name.ts |
Builds timestamped export filenames. |
csv-modal.tsx |
Supplies CSV titles and filenames. |
xlsx-modal.tsx |
Supplies XLSX titles and filenames. |
Suppressed comments (2)
assets/js/src/core/modules/element/listing/batch-actions/csv-modal/csv-modal.tsx:166
- The generated
ExportCsvApiArgcontract still omitsfileName, and thisanycast bypasses request validation rather than updating that contract. Regenerateexport-api-slice.gen.tsfrom the companion OpenAPI schema sofileNameis typed and remove the cast.
config: {
delimiter,
header,
fileName
} as any,
assets/js/src/core/modules/element/listing/batch-actions/xlsx-modal/xlsx-modal.tsx:162
- The generated
ExportXlsxApiArgcontract still omitsfileName, and thisanycast bypasses request validation rather than updating that contract. Regenerateexport-api-slice.gen.tsfrom the companion OpenAPI schema sofileNameis typed and remove the cast.
config: {
header,
fileName
} as any,
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
ValeriaMaltseva
self-requested a review
September 2, 2026 11:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What
Improvements to the grid CSV/XLSX export experience:
ProgressFieldCalculatorcould produce values like15.666666666666668%in the job notification. Progress is now rounded to two decimal places.hideNotificationcallback onJobButtonCustomizationContext.fileName(grid name + timestamp, e.g.Product_2026-09-01_14-32-10.csv) in the export config, which the backend uses for the download's Content-Disposition (see the companion studio-backend-bundle PR).Why
Long unrounded percentages look broken, finished export notifications lingered after the file was downloaded, and generic titles/file names made it hard to tell which grid an export came from when running several exports.
Closes pimcore/platform-version#437