Repository navigation
Keep the library's API docs pages when the docs cache replays - #56
Merged
Merged
Conversation
The docs cache holds Lake's record of the project's docs but not the pages, so a run with unchanged Lean sources replayed the record, generated no pages and deployed the API docs without them. Cache the project's pages too, and stop the run before deployment if a page of the library is missing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every
Physicslib4page of the API docs returns 404 on the live site since #55.Cause. The docs cache holds Lake's record that the project's docs were built, but not the pages. #54 rebuilt everything and saved that cache. #55 had the same Lean sources, so Lake replayed
Physicslib4:docsand generated no pages (5,784 HTML files instead of 5,904). Any later run with unchanged Lean sources would do the same.Fix.
Physicslib4/andPhysicslib4.htmlwith the record. Changing the cached paths also makes GitHub ignore the current cache, so the next deployment rebuilds in full (about 30 minutes more).Checks. Workflow YAML parses; wording check passes; the page check was run on sample trees (complete, one page missing, all missing).
Still to confirm. The caching needs two deployments to prove: this one rebuilds and saves the cache, and a later one with no Lean changes must keep the pages.
🤖 Generated with Claude Code