fix(cli): verify build against pinned phrase-go version before release - #1237
Merged
Conversation
Contributor
API changelog (oasdiff)Doc-only edits (descriptions, examples) do not appear here. |
…g a release phrase-cli's release build compiles against the phrase-go version pinned in go.mod. Our generation pipeline only verified the build against a freshly generated go client via a local replace directive, so a CLI release could be tagged whose generated code outran the phrase-go version actually pinned/published, breaking the public release build (as happened with CLI 2.67.0 vs phrase-go v4.29.1). Add a second build check, scoped to the moment a new CLI version tag is about to be created, using the pinned (non-replaced) dependency exactly as phrase-cli's own release workflow will. This intentionally excludes routine, non-release pushes to phrase-cli's master: generated code there routinely outpaces the last-published phrase-go version between a spec change and its corresponding go client release, and that's harmless since nothing consumes unreleased master content. Release-As: 2.67.1
jablan
force-pushed
the
fix/cli-verify-pinned-phrase-go-build
branch
from
August 24, 2026 13:21
d81d59c to
ade8f3d
Compare
jablan
requested review from
Sven Dunemann (forelabs) and
Sönke Behrendt (theSoenke)
August 24, 2026 13:51
Sven Dunemann (forelabs)
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release.yml) compiles against thephrase-goversion pinned ingo.mod. Our generation pipeline only verified the build against a freshly generated go client via a localreplacedirective, so spec-driven CLI code could ship before the matchingphrase-goversion was actually released — this is exactly what broke the CLI 2.67.0 release build (go.mod pinned to v4.29.1, generated code required v4.30.0 APIs).make buildtarget) that also compiles against the pinned, non-replaced dependency, so this fails in CI here instead of in the public release pipeline.Release-As: 2.67.1is included to prompt release-please to cut a new CLI patch release, sincephrase-gov4.30.0 is already correctly pinned onphrase-climaster — this just needs a new tagged release to go out.Test plan
build-clijob) passes on this PRchore(main): release cli 2.67.1PR2.67.1release build succeeds