Repository navigation
Conversation
phpstan/phpstan-src#5977 models the TypeError PHP 8 throws for an illegal array key. Shopware's SeoUrlGeneratorTest logger declares @throws void but writes $this->logs[$level][$message][] with a string|Stringable key, and a Stringable key throws. A true positive. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QW8VaDtn3cMdQowPSh1xGG
Contributor
|
level is typed as int|string so there should be no type error given the fact phpdoc is trusted |
Author
I agree that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to phpstan/phpstan-src#5977, which models the
TypeErrorPHP 8 throws when an array or object is used as an array key.The shopware integration test then reports one new error, a true positive:
The anonymous logger declares
@throws voidbut does$this->logs[$level][$message][] = $context;withstring|\Stringable $message, and aStringablekey throwsTypeError("Cannot access offset of type Stringable@anonymous on array").This only makes sense together with phpstan-src#5977: merge both or neither.
🤖 Generated with Claude Code
https://claude.ai/code/session_01QW8VaDtn3cMdQowPSh1xGG