Repository navigation
Run rules on CollectedDataNode that do not call get(), and every rule with -vvv - #6881
Merged
ondrejmirtes merged 2 commits intoOct 28, 2026
Conversation
Such a rule works with something other than the collected data, for example a tool that it runs over the whole project. Its errors were reused on every warm run. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
With -vvv the diagnose extensions print, and a rule can fill what they print only while it runs. The rule results are still saved for the next run. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two follow-ups to #6840, from #6840 (comment).
A rule on
CollectedDataNodethat never callsget()now runs every time. Such a rule works with something other than the collected data. For example, pb30/phpstan-composer-analysis runs composer-dependency-analyser over the project and only asksisOnlyFilesAnalysis(). Before, its errors were reused on every warm run. This also holds for a rule that tracks values withDependencyTrackerbut does not callget().With
-vvv, every rule runs too. That is when the diagnose extensions print, and a rule can fill what they print only while it runs. dead-code-detector 1.4.2 shows this:DeadCodeRuleis also aDiagnoseExtension. When its errors were reused,-vvvprinted "Usage debugging is unavailable in files-only analysis." and left out the usages over unknown types. The rule results are still saved, so the next run without-vvvcan reuse them.🤖 Generated with Claude Code