Repository navigation
PHPStan ArrayHandler::getCallableDependencies() guard leaks in method bodies, functions, param defaults, and closures, reflecting full classes on 2-element string arrays - #6758
Open
alfredbez wants to merge 1 commit into
Conversation
…ction call is in progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
ArrayHandler::getCallableDependencies(), the guard introduced in PR #6559 only skips class-level scopes ($scope->getFunction() === null). In method bodies, functions, parameter defaults, and closures, any 2-element array literal['SomeClass', 'string_literal']whose first element resolves to an existing class name triggersConstantArrayType::isCallable(). This callshasMethod()and reflects the entire class into memory, causing large memory spikes for monolithic classes.Reproducer
Expected Behavior
Two-element array literals whose first element is a plain string scalar or not currently within a function call should not reflect the named class as a callable.
getCallableDependencies()should only collect callable dependencies when an active function call is in progress and the first element is an explicitClassConstFetch(Foo::class).