Add regression test for #12882

[HawkForge]

Adds the match (get_class($foo)) case from #12882 to the existing bug-12241.php test. The $foo::class case there already covers the other form. With the sealed handling in GenericClassStringType::tryRemove() disabled, the new block fails with Match expression does not handle remaining value: class-string<Bug12241\Foo> (line 23).

Closes phpstan/phpstan#12882

[staabm]

how is your newly added test different from the one which was committed with the fix in 4cbde15...e38383a ?

[HawkForge]

The $object::class match is the same case bug-12241.php already covers. The new part is the match (get_class($object)) form from #12882, which no existing test covers. With the sealed handling in GenericClassStringType::tryRemove() reverted, it fails with Match expression does not handle remaining value: class-string<Bug12882\BaseClass>.

I can trim the data file down to the get_class() case, or close this if you'd rather not have it.

[staabm]

please append your case in tests/PHPStan/Rules/Comparison/data/bug-12241.php adopted to the pre-existing code in it

[HawkForge]

Done. The get_class() case is now appended to bug-12241.php, and the separate file and test method are gone.

[staabm]

thank you