Repository navigation
Conversation
staabm
requested changes
Oct 17, 2026
staabm
left a comment
staabm
left a comment
Contributor
There was a problem hiding this comment.
only one of the reproducers of the referenced issue is fixed. therefore this PR does not close the issue.
|
|
||
| declare(strict_types = 1); | ||
|
|
||
| namespace Bug11507; |
Contributor
There was a problem hiding this comment.
it seems this snippet was adopted and does not reflect 1:1 the reported reproducer of phpstan/phpstan#11507 (comment) ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a regression test for #11507, reported by @liamduckett. The reproducer from the issue (a
Collection::map()callback that sets$item['foo']on anon-empty-array<string, string>) no longer reports "Function foo() should return Collection<int, non-empty-array<string, string>> but returns Collection<int, non-empty-array<string, string>>" since the bidirectional type narrowing work landed in 2.3.x. The test fails on 2.2.17 with exactly that error and passes on 2.3.x.Closes phpstan/phpstan#11507