Isolate intersection test toggle state - #6255
Open
simPod wants to merge 1 commit into
Open
Conversation
Construct legacy ConstantArrayType fixtures with bleeding edge disabled so reused ParaTest workers cannot change the expected acceptance results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reused ParaTest workers can leave the global bleeding-edge toggle enabled. This changes the array shapes constructed by toggle-sensitive IntersectionType test fixtures and makes their expected trinary results depend on test order.
Construct those fixtures with bleeding edge disabled so they retain their intended unsealed-array semantics without changing the surrounding test state.
Failure in PR #6254: Tests with old PHPUnit (7.4, windows-latest).