Invalidate static expressions when a non-static expression is called - #4434
Open
takaram wants to merge 3 commits into
Open
Invalidate static expressions when a non-static expression is called#4434takaram wants to merge 3 commits into
takaram wants to merge 3 commits into
Conversation
Member
|
Please rebase this and fix conflicts, thank yuo. |
Contributor
Author
|
@ondrejmirtes |
staabm
reviewed
Feb 7, 2026
staabm
reviewed
Feb 7, 2026
staabm
reviewed
Feb 9, 2026
Contributor
There was a problem hiding this comment.
mutating testing suggests, we are missing a unit test for a call which maybe has side effects.
take inspiration from #4422 (comment) if you need a example on how this can be achieved.
staabm
reviewed
Mar 1, 2026
| } | ||
| } | ||
|
|
||
| $expressionTypes = $this->expressionTypes; |
Contributor
There was a problem hiding this comment.
I think we could return early with return $this; when $classNamesToInvalidate is empty
staabm
reviewed
Mar 2, 2026
|
|
||
| if ($methodReflection !== null) { | ||
| if ($methodReflection->getName() === '__construct' || $methodReflection->hasSideEffects()->yes()) { | ||
| $shouldInvalidateExpr = $this->rememberPossiblyImpureFunctionValues |
Contributor
There was a problem hiding this comment.
maybe I misread the PR, but it seems the path where $this->rememberPossiblyImpureFunctionValues is false is not tested ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#13416