Repository navigation
Conversation
…s together - The article link boxes used #2e8b57 on white (4.25:1); they now use #237047 (6:1). - The stylesheet route's 404 carries no hard-coded English text. - version_1_0_0 listed every allowed file extension twice, once per column of the row, and read undefined variables when no extension group was allowed; it now lists each once. It drops the old kb_config.is_dynamic column through phpBB's database tools, which also handle MSSQL, instead of a plain DROP COLUMN. - version_2_0_1 unserializes the old kb_extensions setting without creating objects. - Four test files depended on other tests loading phpBB's utf_tools.php or functions_kb.php and failed, or exited silently, when run alone. - New tests: the legacy steps on SQLite, MySQL and PostgreSQL, an object in the old setting, the empty 404 body, and the link-box contrast in kb_form_access.js. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More fixes found while checking an outside validation report against the Knowledge Base: the article link boxes' contrast, two steps in the oldest migrations, and test files that only passed when the whole suite ran.
Article link boxes
The copy-link boxes on an article page used
#2e8b57on white, 4.25:1; small text needs 4.5:1. They now use#237047, about 6:1.tests/browser/kb_form_access.jschecks it (10 checks now); the check fails on the old colour.Legacy migration steps
version_1_0_0'sset_default_config()listed every allowed file extension twice: its inner loop ran once per column of each row. It also read undefined variables when no extension group was allowed. It now lists each extension once. Boards that already ran it keep the repeats until the ACP extensions page is next saved; that changes nothing in use, since the list only decides which file types uploads accept.kb_config.is_dynamicwith a plainALTER TABLE ... DROP COLUMN. It now uses phpBB's database tools, which also remove the column's default first on MSSQL, where a plainDROP COLUMNfails, and it checks that the column exists.version_2_0_1converts the old serializedkb_extensionssetting withunserialize(..., ['allowed_classes' => false]), so no object is ever created from it. The.github/epv-allowed.txtreason says so.Smaller
The stylesheet route answers a missing file with an empty 404 instead of the English words "Not found".
Tests
kb_alternative_style_test.php,kb_article_text_test.php,kb_board_search_test.phpandkb_recent_changes_test.phpused phpBB'sutf_tools.phpor the extension'sfunctions_kb.phpwithout loading them. They passed only when another test had loaded those first. Run on their own, they failed, or stopped silently with a passing exit code, sinceutf_tools.phpexits whenIN_PHPBBisn't defined. Each now loads what it uses.New
tests/kb_legacy_migration_test.phpruns the old-settings step on SQLite, MySQL and PostgreSQL (the column is gone, each extension is listed once) and checks that an object stored in the old setting is never created.Claude ran:
tests/browser/kb_form_access.js(10 of 10) andtests/browser/kb_page_sweep.js(27 of 27) on fresh seed-forum SQLite boards for phpBB 3.3.19 and 4.0.0-a3-dev.Investigated and written by Claude on behalf of William Jacoby (bonelifer).
🤖 Generated with Claude Code