Style the header's SVG social icons as brand-coloured tiles - #42
Merged
Merged
Conversation
The page headers of the Symfony site, the forum and the old site are switching their social icons from PNGs to inline SVG glyphs with a .social-icons container (paul999/phpbb-website-private#74). Give each link a 20px rounded tile in its brand's colour with the glyph in white, laid out with flexbox and an even 6px spacing, plus hover and focus states. Bump the website.css import in index.css so browsers fetch it again. The PNG rules stay until every deployed header uses the new markup. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The reviewed changes are scoped and have no unresolved blocking issues.
Review effort: Lite
Findings: None
What changed in this PR
Adds scoped styling for inline SVG social icons and updates stylesheet cache busting.
Changes:
- Adds brand-coloured tiles, spacing, SVG fills, and focus states.
- Updates the
website.csscache version.
| File | Summary |
|---|---|
css/website.css |
Styles social icon tiles and interactions. |
css/index.css |
Bumps the stylesheet cache version. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Styles for the new header social icons from paul999/phpbb-website-private#74 (WEBSITE-1433).
The page headers of all three sites (the Symfony site, the forum's prosilver header and the old site) are switching their RSS, Facebook and Twitter PNGs to inline SVG icons for RSS, Facebook, X and Discord, inside a
.social-iconscontainer. This PR adds the styles for that markup:fill: currentColor).:focus-visibleadds an outline for keyboard users.index.cssnow importswebsite.css?6, so browsers fetch the changed file again.The existing
#top-social-icons imgrules stay until every deployed header uses the new markup. The new rules only match.social-icons, so merging and deploying this before the header changes has no visible effect. The PNGs can be removed in a follow-up.This is an interim solution until the website has its own icon font (paul999/phpbb-website-private#40).
Merge order
composer update phpbb/website-assetsin phpbb-website-private and in phpbb/website (the old site's copy also serves/assets/to the forum).issue-74/header-social-iconsin phpbb-website-private, phpbb/website and phpbb3-website (website-proteus).The header markup must not be deployed before this CSS, or the icons render as small unstyled black glyphs.
🤖 Generated with Claude Code