Drop the old team page stylesheet and refresh the navigation import - #32
Merged
Merged
Conversation
team_page_old.css only served the old site's team page, which phpbb/website#229 removes; the team_new selectors in documentation.css belonged to it too. Bump the navigation.css query string so browsers and the CDN fetch the Team menu highlight added in #31. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Removes legacy team-page styling and refreshes the navigation stylesheet cache-buster to align with the team page migration.
Changes:
- Deleted the obsolete
css/team_page_old.cssstylesheet. - Removed leftover
body.team_newselectors fromcss/documentation.css. - Bumped the
navigation.cssimport query string incss/index.cssto invalidate cached copies.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| css/team_page_old.css | Removes the deprecated stylesheet used only by the old team page. |
| css/index.css | Increments the navigation.css cache-busting query string. |
| css/documentation.css | Drops unused body.team_new selector variants while keeping body.support_docs styling. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean-up that goes with the team page migration: phpbb/phpbb-website-private#214 and phpbb/website#229 (issues paul999/phpbb-website-private#14–#17).
What's in it
css/team_page_old.cssis removed. Only the old site's team page loaded it, from theS_IN_TEAMSPAGEblock inoverall_header.html, which phpbb/website#229 removes. The new team page doesn't use it.body.team_newselectors indocumentation.cssare removed. They were leftovers of the same page, and thebody.support_docsrules they shared a line with stay unchanged.navigation.css?2is bumped to?3inindex.css. The Team menu highlight from Highlight the Team menu item on team pages #31 was added without changing that query string. phpbb.com serves assets withmax-age=14400behind Cloudflare, so browsers and the CDN can keep the old copy for hours.Deploying
team_page_old.css.composer update phpbb/website-assetsin phpbb-website-private. The cache-buster only helps onceindex.cssitself is fetched again, so that same change should also bumpassets_versionon theindex.csslink intemplates/base.html.twig.Tested
git grepfinds no other reference toteam_page_oldorteam_newin this repo, phpbb/website with #229 applied, or phpbb-website-private.🤖 Generated with Claude Code