Repository navigation
Use explicit union types for nullable declarations - #36
Conversation
Co-authored-by: iMattPro <303711+iMattPro@users.noreply.github.com>
iMattPro
left a comment
There was a problem hiding this comment.
This PR is against the wrong branch. The failing tests you are fixing is on the develop branch.
Confirmed: PR #36 currently targets |
Co-authored-by: iMattPro <303711+iMattPro@users.noreply.github.com>
Co-authored-by: iMattPro <303711+iMattPro@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #36 +/- ##
=============================================
+ Coverage 98.71% 98.81% +0.09%
+ Complexity 829 820 -9
=============================================
Files 20 20
Lines 2885 3029 +144
=============================================
+ Hits 2848 2993 +145
+ Misses 37 36 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The PHP 8.2 “none” job fails PHPCS because it rejects nullable shortcut syntax. Six declarations now use explicit union types.
?int,?cache, and?arraywithint|null,cache|null, andarray|null.composer.jsonstill declares PHP>=7.2.