Repository navigation
ext/intl: Separate UConverter object lifecycle from method implementations - #24216
Merged
Merged
Conversation
Member
|
that will possibly complicate the merge up later on I feel |
devnexen
reviewed
Oct 10, 2026
LamentXU123
force-pushed
the
intl-ref-20261009
branch
from
October 10, 2026 05:04
0c530d5 to
e1dc9d9
Compare
Member
Author
I was aware. There has been refactorings which is bad to merging up as far as I see (like the zend_string* ones 0d440d3) so I thought sacrifising the convinence when merging up for refactorings is acceptable generally ? |
devnexen
reviewed
Oct 10, 2026
| } php_converter_object; | ||
|
|
||
| static inline php_converter_object *php_converter_fetch_object(zend_object *obj) { | ||
| return (php_converter_object *)((char*)(obj) - offsetof(php_converter_object, obj)); |
Member
There was a problem hiding this comment.
while at it, let s use ZEND_CONTAINER_OF then like other classes do already it seems.
devnexen
approved these changes
Oct 10, 2026
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a good convention of collator, formatter, transliterator, etc, etc. We seperate class stuff into *_class.cpp. The converter.cpp file is now almost 1k line which is hard to maintain.