ext/standard: Adds and modifies XFAIL tests for filter bucket leaks - #23440
Open
NickSdot wants to merge 1 commit into
Open
ext/standard: Adds and modifies XFAIL tests for filter bucket leaks#23440NickSdot wants to merge 1 commit into
NickSdot wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to fix two
warn: XFAIL section but test passesbut found #20058 which already attempts fixing the leaks; don't want to open an overlapping one. However, the PR is already a bit older -- currently builds without leak detection warn becauseXFAILis too broad. So here we change to useSKIPIFto "xfail", "xleak", or skip only where relevant so that we for the time being have no warnings where no leaks can be detected and tests pass. Additionally, two tests for related issues that surfaced were added (also mentioned in #20058 (comment)) .Should this target 8.4 (20058 still targets 8.3)?
cc @Girgias the two modified tests were added by you, are you okay with this change?
cc @iliaal would you want to look at the two added tests?