Skip to content

ext/posix: remove musl pathconf workarounds #22717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orlitzky wants to merge 1 commit into
base: PHP-8.5
Choose a base branch
from
+7 −9
Open

ext/posix: remove musl pathconf workarounds #22717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions ext/posix/config.m4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,7 @@ if test "$PHP_POSIX" = "yes"; then
#endif
])])

dnl Skip pathconf and fpathconf check on musl libc due to limited implementation
dnl (first argument is not validated and has different error).
PHP_C_STANDARD_LIBRARY
AS_VAR_IF([php_cv_c_standard_library], [musl],
[],
[AC_CHECK_FUNCS([pathconf fpathconf])])
AC_CHECK_FUNCS([pathconf fpathconf])

AC_CACHE_CHECK([for working ttyname_r() implementation],
[php_cv_func_ttyname_r],
Expand Down
9 changes: 6 additions & 3 deletions ext/posix/tests/posix_pathconf.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,15 @@ try {
} catch (\ValueError $e) {
echo $e->getMessage(). "\n";
}
var_dump(posix_pathconf(str_repeat('non_existent', 4096), POSIX_PC_NAME_MAX));
var_dump(posix_errno() != 0);

/* POSIX specifically allows implementations to ignore the first
* argument if it will not affect the result. */
$result = posix_pathconf(str_repeat('non_existent', 4096),
POSIX_PC_NAME_MAX);
var_dump( ($result == false && posix_errno() != 0) || is_int($result) );
var_dump(posix_pathconf(sys_get_temp_dir(), POSIX_PC_PATH_MAX));
?>
--EXPECTF--
posix_pathconf(): Argument #1 ($path) must not be empty
bool(false)
bool(true)
int(%d)
Loading