GH-22681: avoid truncation on null bytes in Reflection*::__toString()#22685
Merged
DanielEScherzer merged 3 commits intoJul 13, 2026
Merged
Conversation
Member
Author
|
@Girgias let me know if it would be more helpful to split the fixes into separate commits |
Girgias
reviewed
Jul 13, 2026
Girgias
reviewed
Jul 13, 2026
DanielEScherzer
force-pushed
the
reflection-null-bytes-r2
branch
from
1e4e671 to
a81df44
Compare
Girgias
approved these changes
Jul 13, 2026
Girgias
left a comment
Girgias
left a comment
Member
There was a problem hiding this comment.
One final nit, but LGTM otherwise.
So that when the outputs are fixed the changes can be confirmed in tests
…ng()` Given that there is not an unchecked version of `smart_str_append_printf()`, to avoid compiler warnings from using `%S` to format `zend_string` pointers (which the smart string printing machinery supports, but printf does not support) in a few places the format specifier is declared in a variable rather than being specified directly in the `smart_str_append_printf()` call.
DanielEScherzer
force-pushed
the
reflection-null-bytes-r2
branch
from
a81df44 to
8706cd4
Compare
Member
Author
|
Rebased on top of latest changes, I'll merge this locally so that the commits stay signed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22681