Skip to content

ext/spl: Narrow tentative return types for DirectoryIterator methods #22642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arshidkv12 wants to merge 4 commits into
base: master
Choose a base branch
from
+10 −15
Open

ext/spl: Narrow tentative return types for DirectoryIterator methods #22642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0e972cf
ext/spl: Narrow tentative return types for DirectoryIterator methods
arshidkv12 Jul 8, 2026
1538c2d
ext/spl: Narrow tentative return types for DirectoryIterator methods
arshidkv12 Jul 8, 2026
a2f5afb
ext/spl: Narrow tentative return types for DirectoryIterator methods
arshidkv12 Jul 8, 2026
793efee
ext/spl: Narrow tentative return types for DirectoryIterator methods
arshidkv12 Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ext/phar/tests/phar_oo_004.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,13 @@ class MyDirectoryIterator extends DirectoryIterator
return parent::valid();
}

function key(): mixed
function key(): int
{
echo __METHOD__ . "\n";
return parent::key();
}

function current(): mixed
function current(): MyDirectoryIterator
{
echo __METHOD__ . "\n";
return parent::current();
Expand Down
14 changes: 4 additions & 10 deletions ext/spl/spl_directory.stub.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,17 +123,11 @@ public function rewind(): void {}
/** @tentative-return-type */
public function valid(): bool {}

/**
* @tentative-return-type
* @return int
*/
public function key(): mixed {} // TODO change return type to string
/** @tentative-return-type */
public function key(): int|string {}

/**
* @tentative-return-type
* @return DirectoryIterator
*/
public function current(): mixed {} // TODO narrow return type
/** @tentative-return-type */
public function current(): string|SplFileInfo|RecursiveDirectoryIterator {}

/** @tentative-return-type */
public function next(): void {}
Expand Down
7 changes: 4 additions & 3 deletions ext/spl/spl_directory_arginfo.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading