Improved readonly errors

Zend/tests/property_hooks/abstract_get_only_readonly.phpt

@@ -0,0 +1,18 @@
+--TEST--
+Readonly property satisfies get-only abstract property
+--FILE--
+<?php
+abstract class A {
+    public abstract int $prop { get; }
+}
+class C extends A {
+    public readonly int $prop;
+    public function __construct(int $prop) {
+        $this->prop = $prop;
+    }
+}
+$c = new C(42);
+var_dump($c->prop);
+?>
+--EXPECT--
+int(42)

Zend/tests/property_hooks/abstract_get_set_readonly.phpt

@@ -1,13 +1,16 @@
 --TEST--
-readonly property does not satisfy get/set abstract property
+Readonly property cannot implement set hook of get/set abstract property
 --FILE--
 <?php
-abstract class P {
+abstract class A {
     protected abstract int $prop { get; set; }
 }
-class C extends P {
-    public function __construct(protected readonly int $prop) {}
+class C extends A {
+    protected readonly int $prop;
+    public function __construct(int $prop) {
+        $this->prop = $prop;
+    }
 }
 ?>
 --EXPECTF--
-Fatal error: Class C contains 1 abstract method and must therefore be declared abstract or implement the remaining method (P::$prop::set) in %s on line %d
+Fatal error: Readonly property C::$prop cannot implement set hook required by class A::$prop in %s on line %d

Zend/tests/property_hooks/abstract_get_set_readonly_promoted.phpt

@@ -0,0 +1,13 @@
+--TEST--
+Readonly promoted property cannot implement set hook of get/set abstract property
+--FILE--
+<?php
+abstract class A {
+    protected abstract int $prop { get; set; }
+}
+class C extends A {
+    public function __construct(protected readonly int $prop) {}
+}
+?>
+--EXPECTF--
+Fatal error: Readonly property C::$prop cannot implement set hook required by class A::$prop in %s on line %d

Zend/tests/property_hooks/abstract_get_set_readonly_public.phpt

@@ -0,0 +1,16 @@
+--TEST--
+Readonly property cannot implement set hook of public get/set abstract property
+--FILE--
+<?php
+abstract class A {
+    public abstract int $prop { get; set; }
+}
+class C extends A {
+    public readonly int $prop;
+    public function __construct(int $prop) {
+        $this->prop = $prop;
+    }
+}
+?>
+--EXPECTF--
+Fatal error: Readonly property C::$prop cannot implement set hook required by class A::$prop in %s on line %d

Zend/tests/property_hooks/abstract_get_set_readonly_public_promoted.phpt

@@ -0,0 +1,13 @@
+--TEST--
+Readonly promoted property cannot implement set hook of public get/set abstract property
+--FILE--
+<?php
+abstract class A {
+    public abstract int $prop { get; set; }
+}
+class C extends A {
+    public function __construct(public readonly int $prop) {}
+}
+?>
+--EXPECTF--
+Fatal error: Readonly property C::$prop cannot implement set hook required by class A::$prop in %s on line %d

Zend/tests/property_hooks/abstract_get_set_readonly_public_set.phpt

@@ -0,0 +1,16 @@
+--TEST--
+Readonly public(set) property cannot implement set hook of public get/set abstract property
+--FILE--
+<?php
+abstract class A {
+    public abstract int $prop { get; set; }
+}
+class C extends A {
+    public public(set) readonly int $prop;
+    public function __construct(int $prop) {
+        $this->prop = $prop;
+    }
+}
+?>
+--EXPECTF--
+Fatal error: Readonly property C::$prop cannot implement set hook required by class A::$prop in %s on line %d

Zend/tests/property_hooks/abstract_get_set_readonly_public_set_promoted.phpt

@@ -0,0 +1,13 @@
+--TEST--
+Readonly promoted public(set) property cannot implement set hook of public get/set abstract property
+--FILE--
+<?php
+abstract class A {
+    public abstract int $prop { get; set; }
+}
+class C extends A {
+    public function __construct(public public(set) readonly int $prop) {}
+}
+?>
+--EXPECTF--
+Fatal error: Readonly property C::$prop cannot implement set hook required by class A::$prop in %s on line %d

Zend/tests/property_hooks/interface_get_only_readonly.phpt → Zend/tests/property_hooks/interface_readonly_get_only.phpt

@@ -1,5 +1,5 @@
 --TEST--
-readonly property satisfies get only interface property
+Readonly property satisfies get-only interface property
 --FILE--
 <?php
 interface I {

Zend/tests/property_hooks/interface_readonly_get_set.phpt

@@ -0,0 +1,16 @@
+--TEST--
+Readonly property cannot implement set hook of get/set interface property
+--FILE--
+<?php
+interface I {
+    public int $prop { get; set; }
+}
+class C implements I {
+    public readonly int $prop;
+    public function __construct(int $prop) {
+        $this->prop = $prop;
+    }
+}
+?>
+--EXPECTF--
+Fatal error: Readonly property C::$prop cannot implement set hook required by interface I::$prop in %s on line %d

Zend/tests/property_hooks/interface_readonly_get_set_promoted.phpt

@@ -0,0 +1,13 @@
+--TEST--
+Readonly promoted property cannot implement set hook of get/set interface property
+--FILE--
+<?php
+interface I {
+    public int $prop { get; set; }
+}
+class C implements I {
+    public function __construct(public readonly int $prop) {}
+}
+?>
+--EXPECTF--
+Fatal error: Readonly property C::$prop cannot implement set hook required by interface I::$prop in %s on line %d

Zend/tests/property_hooks/interface_readonly_get_set_public_set.phpt

@@ -0,0 +1,16 @@
+--TEST--
+Readonly public(set) property cannot implement set hook of get/set interface property
+--FILE--
+<?php
+interface I {
+    public int $prop { get; set; }
+}
+class C implements I {
+    public public(set) readonly int $prop;
+    public function __construct(int $prop) {
+        $this->prop = $prop;
+    }
+}
+?>
+--EXPECTF--
+Fatal error: Readonly property C::$prop cannot implement set hook required by interface I::$prop in %s on line %d

Zend/tests/property_hooks/interface_readonly_get_set_public_set_promoted.phpt

@@ -0,0 +1,13 @@
+--TEST--
+Readonly promoted public(set) property cannot implement set hook of get/set interface property
+--FILE--
+<?php
+interface I {
+    public int $prop { get; set; }
+}
+class C implements I {
+    public function __construct(public public(set) readonly int $prop) {}
+}
+?>
+--EXPECTF--
+Fatal error: Readonly property C::$prop cannot implement set hook required by interface I::$prop in %s on line %d

Zend/zend_inheritance.c

@@ -1475,6 +1475,20 @@ static void do_inherit_property(zend_property_info *parent_info, zend_string *ke
 						ZSTR_VAL(ce->name), ZSTR_VAL(key));
 				}
 			}
+			if (parent_info->hooks
+			 && parent_info->hooks[ZEND_PROPERTY_HOOK_SET]
+			 && parent_info->hooks[ZEND_PROPERTY_HOOK_SET]->common.fn_flags & ZEND_ACC_ABSTRACT
+			 && child_info->flags & ZEND_ACC_READONLY
+			 && !property_has_operation(child_info, ZEND_PROPERTY_HOOK_SET)) {
+				zend_error_noreturn(
+					E_COMPILE_ERROR,
+					"Readonly property %s::$%s cannot implement set hook required by %s %s::$%s",
+					ZSTR_VAL(ce->name),
+					ZSTR_VAL(key),
+					zend_get_object_type_case(parent_info->ce, false),
+					ZSTR_VAL(parent_info->ce->name),
+					ZSTR_VAL(key));
+			}
 			if (UNEXPECTED((child_info->flags & ZEND_ACC_PPP_SET_MASK))
 			 /* Get-only virtual properties have no set visibility, so any child visibility is fine. */
 			 && !(parent_info->hooks && (parent_info->flags & ZEND_ACC_VIRTUAL) && !parent_info->hooks[ZEND_PROPERTY_HOOK_SET])) {