ext/ldap: fix ldap_explode_dn result ordering and simplify count handling

[arshidkv12]

#22511

[come-nc]

Looks good to me, basically a revert of 30bc98c

[Girgias]

Just move the add_assoc_long() call prior to the for loop

[Girgias]

Also needs to target a lower branch.

[Girgias]

What?

[arshidkv12]

Sorry, I'm a bit confused. Could you please clarify what you mean?

Is the following correct?

	add_assoc_long(return_value, "count", 0);

	for (i = 0; ldap_value[i] != NULL; i++) {
		add_index_string(return_value, i, ldap_value[i]);
	}
	add_assoc_long(return_value, "count", i);

[come-nc]

Just move the add_assoc_long() call prior to the for loop

The count cannot be added before it’s computed.

I find the implementation in cee392a better than the new one.

[Girgias]

@come-nc I guess this is your new GitHub account compared to @MCMic ?

[come-nc]

@come-nc I guess this is your new GitHub account compared to @MCMic ?

No this is my work account, sorry for the confusion. I still use both (though not that active outside of work these days)

[Girgias]

Right, considering you are more of a maintainer of this extension then I am, feel free to merge this. Do you have commit access (be that either on this account or MCMic)?

[MCMic]

Right, considering you are more of a maintainer of this extension then I am, feel free to merge this. Do you have commit access (be that either on this account or MCMic)?

No it seems I do not have permissions to merge or approve the PR at #22550
Maybe I have permissions at git level, not sure (at least I used to have them for the ext/ldap folder, but not sure how that gets reflected in github).

[EDIT] Found out about https://wiki.php.net/vcs/gitworkflow , currently trying that, will keep you updated ^^

[MCMic]

Right, considering you are more of a maintainer of this extension then I am, feel free to merge this. Do you have commit access (be that either on this account or MCMic)?

No it seems I do not have permissions to merge or approve the PR at #22550 Maybe I have permissions at git level, not sure (at least I used to have them for the ext/ldap folder, but not sure how that gets reflected in github).

[EDIT] Found out about https://wiki.php.net/vcs/gitworkflow , currently trying that, will keep you updated ^^

Nope, following gitworkflow did not help:

$ LC_ALL=en_US.utf8 git push --atomic origin PHP-8.5 master --verbose
Pushing to github.com:php/php-src.git
ERROR: Permission to php/php-src.git denied to MCMic.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

[Girgias]

Right, considering you are more of a maintainer of this extension then I am, feel free to merge this. Do you have commit access (be that either on this account or MCMic)?

No it seems I do not have permissions to merge or approve the PR at #22550 Maybe I have permissions at git level, not sure (at least I used to have them for the ext/ldap folder, but not sure how that gets reflected in github).
[EDIT] Found out about https://wiki.php.net/vcs/gitworkflow , currently trying that, will keep you updated ^^

Nope, following gitworkflow did not help:

Let me ask the relevant people to give you commit access.