Tests: Drop openssl CONFLICTS file

[LamentXU123]

No description provided.

[Girgias]

Wouldn't it be better to make the openssl and mysqli test parallel, rather than faffing with tests that might need to be slow by necessity? (it might even be possible to just remove the conflict file for ext/openssl now that ephemeral ports are used)

[LamentXU123]

The second one is actually slow because the tested behavior is to break the program when memory isn't enough. We could just lower the memory amount to break it way earlier though. The first one is similar (it's testing max execution time. We don't need to wait for the default max execution time)

However, I do agree we can just remove the conflict file for ext/openssl now. Let's do it.

[LamentXU123]

(33.675 s) mysqli_fetch_array() - large packages (to test compression) [D:\a\php-src\php-src\ext\mysqli\tests\mysqli_fetch_array_large.phpt]
(30.397 s) Bug #81145 (copy() and stream_copy_to_stream() fail for +4GB files) [D:\a\php-src\php-src\ext\standard\tests\file\bug81145.phpt]

It is faster for a couple of seconds for every OpenSSL and mysql tests as observed.

[Girgias]

Probably makes sense to split the openssl test changes into its own PR.

[LamentXU123]

I split it. See #22499

[iluuu1994]

See e1ec67a. This was a conscious decision, as these tests caused more failures with parallelization. We do have the retry mechanism now, I don't know if that's enough.

[LamentXU123]

@iluuu1994 I was aware. My point is to change the conflict key from all to mysql. Since ext/mysqli/tests/CONFLICTS and ext/pdo_mysql/tests/CONFLICTS both use mysql, these tests remain serialized with the MySQL test group and should still avoid shared MySQL server contention, and also allow unrelated tests to run in parallel.

wdyt? This is also the same in #22499

[iluuu1994]

See https://github.com/php/php-src/blob/master/ext/mysqli/tests/CONFLICTS. This has no effect, the conflict key is already there. The CONFLICTS all was added after, because running it in parallel with other tests still caused failures. I don't remember the details, but could have been network overload.

[LamentXU123]

I see. I thought this is solved because we now use ephemeral ports.

Given the uncertainty of the result of this PR. I think we can just return to the original idea to lower the ini setting to avoid unnecessary waiting. I am closing #22499

[iluuu1994]

Ephemeral ports solve a different issue (different servers being spun up in parallel). There were different efforts to parallelize tests (avoid conflicting table names), but it looks like the CI change was never merged (i.e. removing the CONCLIFCTS file). Maybe @Girgias remembers why that is.

[Girgias]

Ephemeral ports solve a different issue (different servers being spun up in parallel). There were different efforts to parallelize tests (avoid conflicting table names), but it looks like the CI change was never merged (i.e. removing the CONCLIFCTS file). Maybe @Girgias remembers why that is.

I don't, but the openssl tests work without the CONFLICT file, something @ndossche told me.
For mysqli I don't remember, maybe not all tests got converted?

[ndossche]

I don't, but the openssl tests work without the CONFLICT file, something @ndossche told me.

I've been running the openssl test suite hundreds of times with -j64 in parallel (no exaggeration) with the CONFLCITS file removed, and didn't encounter any issue.
Since openssl migrated to ephemeral ports it should be fine to drop the file I believe.

[LamentXU123]

Given the results of Nora's test, is it safe to drop the openssl CONFLICTS file? @iluuu1994 (any objections?)
(I not yet update the PR)

[bukka]

Keep it in different PR (or at least a different commit when merging). CI is very different to local system in terms of resources so we might need to revert it if we see any failure...

[bukka]

Although maybe leave it for later. I will have some changes comming and still stabilizing the crypto status one so want to do this once all things stabilize and CI is green for some time so I don't need to get disturbed by unrelated failures...

[LamentXU123]

@bukka I directly switch this PR to remove the CONFLICT file (drop the previous one) so if you want to commit feel free to directly push to here.