Fix FD getting code on big endian#17259
Merged
Merged
Conversation
ndossche
reviewed
Dec 24, 2024
stream casting as FD returns a php_socket_t, which is an int, but zend_long is 64-bit (on those platforms). This works on LE by accidental (unless it forgets to clear the high word), but is fatal on big endian.
NattyNarwhal
force-pushed
the
fix-big-endian-fd-8.3
branch
from
67f1d2b to
0d4cf47
Compare
devnexen
reviewed
Dec 25, 2024
devnexen
approved these changes
Dec 26, 2024
devnexen
left a comment
devnexen
left a comment
Member
There was a problem hiding this comment.
Hopefully your ppc CI PR will work out
NattyNarwhal
added a commit
that referenced
this pull request
Dec 30, 2024
* PHP-8.3: Fix FD getting code on big endian (#17259)
NattyNarwhal
added a commit
that referenced
this pull request
Dec 30, 2024
* PHP-8.4: Fix FD getting code on big endian (#17259)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stream casting as FD returns a php_socket_t, which is an int, but zend_long is 64-bit (on those platforms). This works on LE by accidental (unless it forgets to clear the high word), but is fatal on big endian.
fb2443a in master seems to have made this obvious, but the issue exists in earlier versions too. Fixes a regression introduced by that commit on big endian. (see GH-17258 for CI there)