Skip to content

Fix InternalClassMustBeFinalRule needs implements ExtendedClassAwareRuleInterface - #339

Merged
roxblnfk merged 1 commit into
php-testo:1.xfrom
samsonasik:fix-internal-class-fin
Sep 14, 2026
Merged

Fix InternalClassMustBeFinalRule needs implements ExtendedClassAwareRuleInterface#339
roxblnfk merged 1 commit into
php-testo:1.xfrom
samsonasik:fix-internal-class-fin

Conversation

@samsonasik

Copy link
Copy Markdown
Contributor

What was changed

Change implements interface required to make use of:

$classNode->isExtended

on InternalClassMustBeFinalRule

Why?

The ExtendedClassAwareRuleInterface is required to detect child classes, see documentation

https://boundwize.github.io/structarmed/custom-rules-and-presets/#reading-usage-flags-in-a-custom-rule

Checklist

  • Tested
    • Tested manually

Fixes #338

@samsonasik

Copy link
Copy Markdown
Contributor Author

@roxblnfk ready to merge 👍

@roxblnfk
roxblnfk merged commit 4f4defe into php-testo:1.x Sep 14, 2026
@samsonasik
samsonasik deleted the fix-internal-class-fin branch September 14, 2026 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

structarmed: use of classNode->isExtended needs implements ExtendedClassAwareRuleInterface

2 participants