Use React Router Form for save-changes submission - #44
Open
tayloraj10 wants to merge 1 commit into
Open
Conversation
Convert the "Save changes" button on the review detail page from a bare onClick handler to a <fetcher.Form onSubmit>, matching the approve/reject actions that already use <Form>. The payload is a nested object rather than flat fields, so it's still sent as JSON via fetcher.submit, but routing it through a real form gives us proper submit semantics (Enter-to-submit, pending state, progressive enhancement) instead of a plain button click. Also swap the deprecated FormEvent type for SubmitEvent, and convert logout to a POST action (was a GET loader) triggered via a <Form> in the sidebar, since a GET route shouldn't perform a mutation like signing out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use React Router Form for save-changes submission
Problem
The "Save changes" button on the review detail page was a plain
<Button onClick={...}>, unlike the approve/reject buttons on the same page which already use<Form>. This inconsistency meant "Save changes" lacked proper submit semantics (Enter-to-submit, pending state via native form submission, progressive enhancement). Separately, thelogoutroute performed its sign-out mutation from aloader(i.e. a GET request), which is semantically incorrect since GET requests shouldn't have side effects like signing a user out. TheFormEventtype used in the save handler was also deprecated.Solution
<fetcher.Form onSubmit>, matching the pattern already used for approve/reject. The payload is still a nested object rather than flat fields, so it's serialized and sent as JSON throughfetcher.submitinside theonSubmithandler (withevent.preventDefault()), but it's now wired to a real form element.FormEventtype withSubmitEventin the save handler.logoutfrom aloader(GET) to anaction(POST): the loader now just redirects to/if hit directly via GET, and the actual sign-out mutation lives in theaction.<Link>to a<Form method="post" action="/logout">with a submit button styled to match the original link.Reference
N/A
Screenshots
N/A (no visual changes — logout button and save button retain their existing appearance/styling)
Checklist