Repository navigation
Give each WebGL context its own graphics data pool - #764
Open
asger-finding wants to merge 1 commit into
Open
asger-finding wants to merge 1 commit into
asger-finding wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Describe the changes below:
PIXI.WebGLGraphics.graphicsDataPoolwas shared by all WebGL contexts, andswitchModepopped from it without checking the context. So a Graphics in one game could get WebGLGraphicsData whose buffers belong to another game's context, or to a destroyed game's, and then fail every draw with the warningWebGL: INVALID_OPERATION: bindBuffer: object does not belong to this context.Now each context has its own pool, set in
WebGLRenderer#initContext(which also drops pooled buffers of a lost context on restore) and nulled inWebGLRenderer#destroy, alongsidePIXI.glContextsandPIXI.instances.This caused an extremely rare but crazy bug in our game. See below.
To reproduce:
Crate: