Repository navigation
Conversation
Passkeys (WebAuthn, via py_webauthn and @simplewebauthn/browser) work as a second factor alongside or instead of TOTP, sharing one set of recovery codes issued with the first factor and deleted with the last. Adding, removing or changing a factor needs proof of an existing one on top of a fresh session; sign-in offers every method the account has, and a code lockout leaves passkeys usable. The account page gets a review step for new passkeys (provider and name inferred from the AAGUID), method tabs for proofs, a split TOTP setup wizard, passkey details, and a redesigned second-factor sign-in screen. Passkeys are bound to the Console's own domain (first ALLOWED_ORIGINS entry); no new settings or server secrets.
The verify endpoint returned the PasskeyError's own text and code. They were always fixed strings, but the response now takes both from the message table so no exception data reaches the client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passkeys (WebAuthn) as a second factor, alongside or instead of TOTP.
What users get
/login/mfawith nothing pending redirects to/login.Security
ALLOWED_ORIGINSentry). No new env vars or server secrets.Testing
test_passkeys.pyplus updated MFA tests (172 in the 2FA suites); full suite passes apart from the 5 tests that fail on main in the dev container.Docs: phasehq/docs#274