Repository navigation
Simplification of environmental handling - #303
Conversation
Code Coverage SummaryDiff against mainResults for commit: 8ce829c Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Test Performance DifferenceAdditional test case details
Results for commit a6eaa5f ♻️ This comment has been updated with latest results. |
Unit Tests Summary 1 files 14 suites 7s ⏱️ Results for commit 62c0e18. ♻️ This comment has been updated with latest results. |
averissimo
left a comment
There was a problem hiding this comment.
Left a comment thread so we can discuss this
…code into 272_valid_reproducible
averissimo
left a comment
There was a problem hiding this comment.
Last round of comments as I think we need to revert to use parent of (now) default_env
I recommend adding a few more tests to protect the package against the initial design principles and what we learned here
averissimo
left a comment
There was a problem hiding this comment.
Awesome! We couldn't deal with the issue, but this PR makes the package more robust
Pull Request
Fixes #272
Replaces the base environment to an "empty", only those packages loaded by default. These are found via a new helper
default_env()added. Note that the private function is used also on tests, but I am not sure if there is any work around that avoids duplicating it.Check out if
.eval_code()should be amended too, it is the only place where if I replace it something starts to fail, but I don't understand the evaluate framework enough to know if this is a mistake or not.Also check the tests added. They should be skipped online but run locally. Checking with
R CMD check --as-cranlocally didn't trigger any Note about undeclared package.Last not not least. This might create havoc across modules and apps, if we forgot to add a dependency inside qenv, once this is merged it will reveal itself.
To verify the fix run these lines that the last one should fail:
In relation to #201, we might want to change some environment to the environment of the object before the evaluation.