Skip to content

Allowlist exact Puppies.com hosts and document false-positive review - #1835

Open
Sammy12357 wants to merge 1 commit into
phantom:masterfrom
Sammy12357:agent/allowlist-puppies-com
Open

Allowlist exact Puppies.com hosts and document false-positive review#1835
Sammy12357 wants to merge 1 commit into
phantom:masterfrom
Sammy12357:agent/allowlist-puppies-com

Conversation

@Sammy12357

@Sammy12357 Sammy12357 commented Aug 13, 2026

Copy link
Copy Markdown

Summary

  • allowlist the exact first-party hosts puppies.com and www.puppies.com
  • document a narrow, evidence-based process for future false-positive reports

Why

puppies.com is being flagged by Phantom even though neither it nor its www
host appears in this repository's Solana or Ethereum blocklists. That points to
a heuristic or an upstream reputation-source false positive rather than an
explicit entry in this repository.

There are multiple independently verifiable signals that these are established
first-party hosts:

Puppies.com is a user-generated marketplace, so this change does not claim
that every listing or seller is trustworthy. It only prevents the verified
first-party website hosts from being treated as wallet-phishing domains.

Precision and security scope

This deliberately does not add *.puppies.com. Only the apex and the www
redirect target are excepted. Unreviewed subdomains, deceptive sibling domains,
and suffix tricks remain outside the allowlist.

The README guidance applies the same principle to future reports: use exact
hosts, require independently checkable evidence, document redirects, and treat
reputation scans as supporting rather than decisive evidence. This mirrors a
multi-signal URL-review approach while keeping the deployed data format
unchanged.

Validation

  • yarn install --frozen-lockfile
  • node ./ci.js
  • yarn run build
  • generated-data assertions confirming only puppies.com and
    www.puppies.com are allowlisted, while shop.puppies.com,
    fakepuppies.com, and puppies.com.evil.example are not

Summary by CodeRabbit

  • New Features

    • Added puppies.com and www.puppies.com to the URL whitelist.
  • Documentation

    • Added guidance for reporting false positives, including whitelist formatting, wildcard usage, and supporting evidence.

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c263a6ce-bcdc-4465-8070-220effdec3af

📥 Commits

Reviewing files that changed from the base of the PR and between 5030186 and 05cd193.

📒 Files selected for processing (2)
  • README.md
  • whitelist.yaml

📝 Walkthrough

Walkthrough

The pull request adds guidance for reporting false positives and whitelists puppies.com and www.puppies.com.

Changes

Whitelist updates

Layer / File(s) Summary
Whitelist policy and entries
README.md, whitelist.yaml
The README documents hostname verification, conservative wildcard use, evidence, and redirect context. The whitelist adds puppies.com and www.puppies.com.

Mergeability Score: ⚪ Minimal · up to 05cd1

The change narrowly allowlists two exact first-party hosts and documents review guidance without broadening subdomain coverage; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change by naming the exact Puppies.com hosts and the related false-positive review documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant