Repository navigation
Align released Go dependencies and regenerate Swagger for Console - #86
Merged
Merged
Conversation
Signed-off-by: Feng Ruohang <rh@vonng.com>
Signed-off-by: Feng Ruohang <rh@vonng.com>
Keep production lease, heartbeat and scan timeout defaults. Hold inventory until PostgreSQL confirms the original lease has expired and the observer renewed it, then require reconciliation and the inventory bucket to be persisted. The observer implementation and required CI gates are unchanged. Signed-off-by: Feng Ruohang <rh@vonng.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Console still selected silo-pkg v3.15.2 and the October MC release. This adopts the released November components and upgrades Swagger independently, with focused Console regression coverage and unchanged CI gates.
Three DCO-signed commits, based on main
efe12ae972579972327b0d56e085fcfc8ba62923:47745554ab598c76472aeb15034da12b39be2f07: require silo-pkg v3.16.0 (b7aeea85e84e8888d6ab424c7123a1297711bc3f); retaingithub.com/minio/mcimports and replace withgithub.com/pgsty/mc v0.0.0-20261109021353-e1d4cc5abfe0, the publishedRELEASE.2026-11-09T00-00-00Zcommite1d4cc5abfe00b674eb36347399e7398990be467. Refresh release metadata, generated replacement/credits records and English/Chinese entry-point documentation without changing v2.6.0 history.77a4551e6f695f23908cbfc0a26480d0dbaac6ab: use go-swagger v0.36.7 with runtime and server-middleware v0.33.4. Regeneration changes only 50 array-context early returns to continues across 46 models. Preserve the customized server, configuration-import binder/consumer, schema and TypeScript client. Fix the existing SPA interception of/swagger.json, which prevented the generated documentation page from loading its spec.53aff8bdc3182d7c78693c95403f3733f9e86588: make the existing observer-renewal regression use production defaults and synchronize with PostgreSQL lease expiry. The initial CI run failed with its unsupported 50 ms heartbeat/300 ms lease settings. Inventory is held beyond the original database deadline, renewal must remain live, and the inventory bucket and reconciliation must be persisted. No usage runtime code or CI gates change.Dependency selection is deliberate:
0ceb298cdcd0→e1d4cc5abfe04974bb2c981b<<keysNo JOSE vulnerability fix in the standalone Console binary is claimed. Go remains 1.27.3; upstream minio-go remains
v7.4.2-0.20261025165926-320af050c445; x/net remains v0.62.0 and x/crypto remainsv0.58.1-0.20261009181718-2f1f834330b2. Effective tablewriter v0.0.5, runewidth v0.0.29 and go-systemd v22.6.0 replacements remain. Indirect minio/pkg is still reached through minio/colorjson and is not replaced.gjson v1.20.2/pretty v1.3.0 are deferred because they change formatting. pgx/puddle require a separate usage/PostgreSQL assessment. pb, humanize, Prometheus, gRPC and cloud SDK updates have no demonstrated need in this change. Runtime, tool and graph-only changes are kept distinct.
Local validation passed: repeated tidy without drift, module verification, verifiers, replacement checks, structural/online dependency release verification, downstream embedder build/vet, Go unit tests, API/pkg race tests and govulncheck (no vulnerabilities found). The full PostgreSQL/SILO storage-integration suite also passed locally. A real SILO regression under the existing required job covers the MC adapter's version reads, delete markers, exact-key purge boundaries, errors and watch cancellation; diagnostics and ILM contracts are tested. Swagger generation reproduced 763 files byte-for-byte; config-import and API binder tests pass; Chromium rendered Redoc 3 and its specification without browser errors.
The observer test now uses the production two-minute lease and 15-second heartbeat, with no test-specific timing overrides. On final head, the full PostgreSQL/SILO storage suite passes with the race detector (
pkg/usage: 143s,api: 46s). A temporary Go overlay disabling renewal fails at the original two-minute database expiry, confirming the regression is still detected. Repeated tidy, module verification, verifiers and Go unit tests also pass.CI for exact head
53aff8bdc3182d7c78693c95403f3733f9e86588: Required vulnerability checks passed; Required matrix passed. All 38 matrix jobs and all 3 vulnerability workflow jobs succeeded on that exact head. Browser regression results: 886 tests passed plus 8 group-boundary tests. Final-head online verification also confirms both published dependency tags and full source commits against the public Go proxy, checksum database and go.sum.The original uncommitted work was preserved separately; this PR used an isolated worktree. Investigation logs and temporary artifacts stay outside Git. This PR prepares an unreleased Console candidate; it does not publish Console, create a release tag or push a release image.