fix(conf): declare MinIO users in ha/trio template - #773
Merged
Conversation
The ha/trio template enables MinIO as the pgBackRest repository but does not declare minio_users. When configure -g is used, the S3User.Backup value in pgbackrest_repo is randomized while the MinIO user continues to inherit the default secret from the role. Declare the default MinIO users explicitly so generated credentials remain consistent.
Member
|
Thanks for catching this and providing a focused fix. This keeps the generated MinIO and pgBackRest credentials consistent in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ha/trio template enables MinIO as the pgBackRest repository but does not declare minio_users. When configure -g is used, the S3User.Backup value in pgbackrest_repo is randomized while the MinIO user continues to inherit the default secret from the role.
Declare the default MinIO users explicitly so generated credentials remain consistent.
Problem
The
ha/triotemplate deploys MinIO and enables it as the pgBackRestrepository, but it does not explicitly declare
minio_users.When generating the configuration with:
configure -greplacesS3User.Backupin:pgbackrest_repo.minio.s3_key_secretHowever,
minio_usersis absent from the generated configuration, sothe MinIO role continues to use its default
S3User.Backupsecret.This results in different credentials being used by MinIO and
pgBackRest, causing:
during
pgbackrest stanza-create.Root cause
Password generation performs string replacement only on values present
in the selected configuration template. The
ha/triotemplate containsthe pgBackRest S3 secret but not the corresponding MinIO user definition.
Fix
Explicitly declare the standard MinIO users in the
ha/triotemplate,following the same pattern used by other templates that enable MinIO
backups.
This allows
configure -gto replace both the MinIO user secret and thepgBackRest S3 secret with the same generated value.