feat(stats): add banned gauge to pool metrics - #1443
Open
ChrisJr404 wants to merge 1 commit into
Open
Conversation
|
|
levkk
approved these changes
Aug 27, 2026
levkk
left a comment
Collaborator
There was a problem hiding this comment.
Cool! Happy to merge if you sign the CLA.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1424. Adds a
bannedgauge to the per-pool OpenMetrics output so you can alert on a database being banned instead of inferring it from the socket counts, which don't reliably drop to zero for every kind of failure.It reuses the same ban state that
SHOW BANSreports (switched the metrics loop topools_with_roles_and_bans), emitting one measurement per pool with the usual database/user/host/shard/role labels: 1 when the pool is banned, 0 when it's available. Added a render test next to the existing pool metric tests.