Repository navigation
Conversation
When the websocket closes, receive() returns null, so fetch() hands back an empty string and json_decode() turns that into null. Neither the error branch nor the break condition can match null, so execute() keeps looping until something outside the test kills it. Throw a ServerNotFoundException instead, and add a unit test that gives the client a connection whose receive() returns null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the Playwright server's websocket closes,
receive()returnsnull,fetch()turns that into an empty string, andjson_decode('')givesnull. None of the checks inexecute()can matchnull, so the loop never ends and the run just sits there until some outer timeout kills it.This throws a
ServerNotFoundExceptionwhen a frame doesn't decode to an array, so the test fails with a message instead of hanging.I added a unit test that sets a mocked connection whose
receive()returnsnull. Without the change it never finishes (I had to kill it after 20 seconds). With it, it passes in well under a second. Locally I only ran that test and PHPStan onsrc, not the full suite.Happy to use a different exception if you'd rather keep
ServerNotFoundExceptionfor the HTTP server.