Branding to 6.2.0 - #3042
Merged
Merged
Conversation
Prerelease is empty and ReleaseNotes points at the 6.2.0 tag, so the manifest that gets packaged says 6.2.0 and not 6.2.0-alpha2. The release notes get their last pass: title, the prerelease install line, and the compare link. Fixed the applied-setup-files example, it showed a rendering of the data with no code to produce it. Added the multiple BeforeAll to the summary and a line saying the setup files have to be safe to run more than once. 🤖
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prereleaseis empty andReleaseNotespoints at the 6.2.0 tag, so the manifest that gets packaged says 6.2.0 and not 6.2.0-alpha2.docs/NEXT-RELEASE.mdgets its last pass: the title, the prerelease install line, and the compare link. Nothing user facing merged since the alpha2 notes pass in pester/Pester#3037 — Write the 6.2.0-alpha2 release notes pass. The two that came after it, pester/Pester#3039 — Skip the build and the test matrix on a documentation-only pull request and pester/Pester#3040 — Reset the exit code when the test harness finishes a passing run, touch the CI lane andtest.ps1, so there is nothing new to write up.The examples
I built this branch and ran every example in the notes against it, and compared the output to what the notes claim.
The
Should-BeStringdiffs (both of them), the three stack trace failures, theBeforeAllthat throws, the three strict configuration errors, the unknown key warning and the timing assertion message all print exactly what the notes say. The folder cascade repro passes: root,tests,tests/unit,tests/integration, and atests/docsmarked#pester:no-inherit, and the docs file gets only its own setup.One example was wrong. The block showing which setup files applied to a container was a rendering of the data with no code that produces it, so a reader had no way to get to it. The list is
BeforeContainerFileon the container in the result object, and the notes now show the loop that prints it, next to the output that loop actually produced:Two things the notes did not say and now do. A block can have more than one
BeforeAll, which was only a bullet in the behavior changes at the bottom, and it is a feature people asked for, so it is in the summary paragraph too. And the setup files run before every container, so what they do has to be safe to run more than once. That one is in theRun.RepoRoothelp text and was nowhere in the notes.Order
Publishing the draft release is what creates the tag, so this has to be merged before that happens, otherwise the tagged commit still carries
Prerelease = 'alpha2'and that manifest is what ships to the gallery.docs/NEXT-RELEASE.mdis emptied for the 6.3.0 line after the release is out, in its own PR, not here. The notes have to stay in the file until they are copied into the release body.🤖