Skip to content

[BUGFIX] fix race condition with initial query plugin spec#199

Merged
Nexucis merged 1 commit into
perses:mainfrom
andreasgerstmayr:fix-initial-plugin-spec
Jul 16, 2026
Merged

[BUGFIX] fix race condition with initial query plugin spec#199
Nexucis merged 1 commit into
perses:mainfrom
andreasgerstmayr:fix-initial-plugin-spec

Conversation

@andreasgerstmayr

Copy link
Copy Markdown
Contributor

Description

useDefaultQueryDefinition() returned isLoading: false while the plugin was still loading (only the metadata loading state was checked). This caused the initial plugin spec to be set to {} because defaultQueryPlugin was undefined.

Fix by combining both the metadata and plugin loading states into a single composite isLoading flag.

Screenshots

no visible UI changes

Checklist

  • Pull request has a descriptive title and context useful to a reviewer.
  • Pull request title follows the [<catalog_entry>] <commit message> naming convention using one of the
    following catalog_entry values: FEATURE, ENHANCEMENT, BUGFIX, BREAKINGCHANGE, DOC,IGNORE.
  • All commits have DCO signoffs.

UI Changes

  • Changes that impact the UI include screenshots and/or screencasts of the relevant changes.
  • Code follows the UI guidelines.
  • E2E tests are stable and unlikely to be flaky.
    See e2e docs for more details. Common issues include:
    • Is the data inconsistent? You need to mock API requests.
    • Does the time change? You need to use consistent time values or mock time utilities.
    • Does it have loading states? You need to wait for loading to complete.

useDefaultQueryDefinition() returned isLoading: false while the plugin
was still loading (only the metadata loading state was checked). This
caused the initial plugin spec to be set to {} because
defaultQueryPlugin was undefined.

Fix by combining both the metadata and plugin loading states into a
single composite isLoading flag.

Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com>
@andreasgerstmayr
andreasgerstmayr requested a review from a team as a code owner July 15, 2026 16:15
@Nexucis
Nexucis merged commit 5e546ba into perses:main Jul 16, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants