[FEATURE] add column settings to logs table#698
Conversation
jgbernalp
force-pushed
the
feat/logstable-column-settings
branch
2 times, most recently
from
da3add0 to
2209870
Compare
jgbernalp
force-pushed
the
feat/logstable-column-settings
branch
from
2209870 to
43f5696
Compare
|
I am wondering if it could re-use column settings from |
jgbernalp
force-pushed
the
feat/logstable-column-settings
branch
2 times, most recently
from
1005c87 to
0be660b
Compare
I wanted to add a simple feature. I think in the future this logs table should be replaced by the table plugin. We just need to add support for log queries there. |
jgbernalp
force-pushed
the
feat/logstable-column-settings
branch
from
0be660b to
b0935eb
Compare
jgbernalp
force-pushed
the
feat/logstable-column-settings
branch
4 times, most recently
from
026a591 to
399ad7f
Compare
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
jgbernalp
force-pushed
the
feat/logstable-column-settings
branch
from
399ad7f to
f0b667a
Compare
| onUpdate={handleUpdateColumn} | ||
| onMoveUp={handleMoveUp} | ||
| onMoveDown={handleMoveDown} | ||
| renderNameField={(col, index, onUpdate) => ( |
There was a problem hiding this comment.
Why passing name field, width and wrap as props? 🤔
| </Box> | ||
| ); | ||
|
|
||
| if (!allowWrap) { |
There was a problem hiding this comment.
Is it working for you?
When I disable wrapping and hover on it, I don't see tooltip 🤔
There was a problem hiding this comment.
Ok I saw LogRow code just after, log line is hardcoded with case, we may want to add the same logic to it
| {ansiHtml ? ( | ||
| <LogText | ||
| variant="body2" | ||
| allowWrap={column.allowWrap ?? allowWrap} |
There was a problem hiding this comment.
Ref to prev comment, we don't have tooltip if allowWrap disabled
2 participants
Description
This PR adds column settings for the logs table
related to:
perses/perses#3786
perses/perses#4143
Screenshots
Screen.Recording.2026-06-24.at.15.20.39.mov
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.UI Changes