Repository navigation
Ask Pix or USDC before starting a Stocks checkout - #1464
Merged
Merged
Conversation
With both methods open, a signed-in user's Comprar and Vender opened the Pix flow, which offered USDC only as a small secondary option. A USDC tester continued on Pix and ended up in the Pix identity check, which a Base USDC order does not need. Both flows now start on an explicit Pix-or-USDC choice, as Gold's picker does, unless the user already chose Pix in the preview or is resuming an operation.
✅ Deploy Preview for vortexfi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vrtx-dashboard canceled.
|
…open The backend opens each Base USDC direction apart from Pix, but the Pix flows offered USDC whenever the checkout flag was on. With only USDC buys open, a seller could pick USDC and only learn after entering an amount that the route was unavailable. App now reads the live USDC listing once per runtime and passes the USDC handler to the buy or sell flow only when that direction is listed for the token (usdcOpen). An unread or failed listing offers Pix only; the simulated checkout stays open. LiveUsdcFlow still re-checks before every quote.
…p paths The sell method step announced its group as "Forma de pagamento" under the heading "Como deseja receber?"; it is now "Forma de recebimento". Tests now cover going back from the sell amount to the choice, and that a resumed Pix operation and the buy-quote and sell-reserve-used demo links skip it. The stock-page regression test asserts that "Comprar" became enabled before clicking it, so a pending operation left by another test fails with a clear message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Brazil Stocks app, a signed-in user's Comprar and Vender opened the Pix flow whenever Pix was open. USDC on Base appeared only as a small secondary option inside it, so a tester who wanted to pay with USDC continued on Pix and reached the Pix identity check, which a Base USDC order does not use.
buy-quoteandsell-reserve-useddemo links. With USDC off (production today), the flows are unchanged.apps/stocks/CLAUDE.mdnotes the step and the direction check (usdcOpenindetail-actions.js).Validation: 420 Stocks tests pass, including five new tests and one updated test. The tests for the choice itself fail on the current
stagingcode. They cover:bun lintandbun build:stockspass. In a local demo build, the buy (Pix, back, USDC) and the sell were checked in the browser on desktop and at 375 px, with no console errors, and the sell choice's label was confirmed.scripts/verify-usdc-ui.mjstargets the same labels but was not run.