Repository navigation
Prepare Gold on Base with Pix and USDC checkout - #1461
Merged
Merged
Conversation
✅ Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vortexfi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vrtx-dashboard canceled.
|
The SDK key callback saves an Ethereum buy at stage "registering". The later save after registration passes no stage, and the shared-store wrapper spread the existing record under it, so the stage stayed "registering". On resume, TransactionFlow then refused to show the Pix QR. Carry over only createdAt, so a save without a stage means "registered" again, as it did before the shared store.
A URL-less viem http() falls back to eth.merkle.io for mainnet, which refuses the browser's CORS preflight, so every balance read failed and selling was disabled. Use Privy's app-scoped RPC, which the embedded wallet's provider used before, for Ethereum and Base.
# Conflicts: # docs/security-spec/01-auth/consumer-apps.md # packages/sdk/src/VortexSdk.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare the Gold checkout for official PAXG on Base while retaining the Ethereum default, existing Privy identity and Ethereum recovery. The opt-in client offers Pix/BRL and native Base USDC in both buy and sell directions. USDC funding remains in the user wallet, waits for two confirmations and requires a fresh quote and explicit authorization before registration. Partial/excess/late funds remain available.
The SDK adds a narrow same-chain USDC/PAXG adapter using common ephemeral persistence/presigning. The client pins delivery identity and source permits, uses consumer-kit locks/recovery, and retains Ethereum holdings separately. Base and USDC build gates default off. No production activation is included.
Backend dependency: this PR adds no server corridor. The API must list the canonical PAXG Base contract per rail/direction and provide matching quotes, registration and destinationTransfer. USDC buys and both sells require gasless exact-source authorization in goldPermitTransfer, as specified in apps/gold/README.md. Confirm this contract against the final backend; a different wallet request is deliberately refused. check:base currently reports the canonical token missing. It performs only anonymous listing/quote checks and no payment. Real-wallet and settlement acceptance remain open.
Validation: 55 Gold, 187 SDK (including package type/browser/Node checks), 127 consumer-kit and 378 existing Stocks tests passed. Root lint/wire checks and Gold live builds with the Base gates off/on passed. Synthetic USDC funding/re-review/buy/sell was exercised in the browser, including 390x844 mobile. Read-only Base checks returned PAXG, 18 decimals and a nonce. No real identity, wallet signature, payment or bank settlement was submitted.