Repository navigation
ci: Install protoc from GitHub releases in the shared action - #595
Merged
Merged
Conversation
The shared action installed protobuf with apt after an apt upgrade, so clippy and test runs failed whenever the Ubuntu package mirror was unreachable from the runners. Install protoc with setup-protoc there instead, which also covers the clippy job, and drop the duplicate step from the test workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
apt-get update && apt-get upgradeand installs protobuf from the Ubuntu mirror. It installs protoc witharduino/setup-protocinstead, the same pinned action the test workflow already used.Why
Clippy and test runs on main have been failing in the install step because
azure.archive.ubuntu.comdid not resolve on the runners. With this change, CI no longer depends on the Ubuntu package mirror, and skipping the fullapt-get upgradeshortens every run.Testing